GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-116738: make `mmap` module thread-safe (GH-139237) by kumaraditya303 · Pull Request #139825 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Oct 9, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 7f155f9)

  • Issue: Audit all built-in modules for thread safety #116738

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@yoney @kumaraditya303
[3.14] pythongh-116738: make mmap module thread-safe (pythonGH-139237)
ff5b964 
(cherry picked from commit 7f155f9)

Co-authored-by: Alper <[email protected]>
This was referenced Oct 9, 2025
Audit all built-in modules for thread safety #116738
Open
gh-116738: Make mmap module thread-safe #139237
Merged
@bedevere-app bedevere-app Bot added the topic-free-threading label Oct 9, 2025
@kumaraditya303
fix flush
8948ed8
@kumaraditya303
kumaraditya303 force-pushed the backport-7f155f9-3.14 branch from 0f40830 to 8948ed8 Compare October 9, 2025 06:57
@kumaraditya303
remove resize tests
2c66c93
@kumaraditya303
kumaraditya303 marked this pull request as ready for review October 9, 2025 13:34
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 9, 2025
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 9, 2025
@bedevere-bot

bedevere-bot commented Oct 9, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 2c66c93 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139825%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 9, 2025
@kumaraditya303
kumaraditya303 requested a review from vstinner October 9, 2025 13:45
vstinner
vstinner approved these changes Oct 9, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(cherry picked from commit 7f155f9)

I suppose that it's a straightforward backport. I'm fine with it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 9, 2025
@kumaraditya303

kumaraditya303 commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

I suppose that it's a straightforward backport. I'm fine with it.

There's an additional fix 8948ed8 because bd1ada6 wasn't backported but the rest is same.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 merged commit 926d734 into python:3.14 Oct 9, 2025
34 of 37 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 deleted the backport-7f155f9-3.14 branch October 9, 2025 14:49
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@kumaraditya303 @bedevere-bot @vstinner @yoney
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.