GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131178: add tests for `filecmp` command-line interface by fatelei · Pull Request #139947 · python/cpython

Conversation

@fatelei

@fatelei fatelei commented Oct 11, 2025

Copy link
Copy Markdown
Contributor

gh-131178 filecmp command interface add unittest

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Oct 11, 2025
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app bedevere-app Bot added the awaiting review label Oct 11, 2025
@fatelei
fatelei force-pushed the cli_bas64_ut branch from 04af1c8 to 927a9db Compare October 11, 2025 09:32
@bedevere-app

This comment was marked as resolved.

Sign in to view
@fatelei
fatelei force-pushed the cli_bas64_ut branch from 927a9db to 3258540 Compare October 11, 2025 09:38
@bedevere-app

This comment was marked as resolved.

Sign in to view
@picnixz picnixz changed the title chore: filecmp add unittest gh-131178: add tests for filecmp command-line interface Oct 11, 2025
@picnixz picnixz added the skip news label Oct 11, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 11, 2025
Add tests for command-line interface #131178
Open
7 of 9 tasks
picnixz
picnixz reviewed Oct 11, 2025
View reviewed changes
Comment thread Lib/test/test_filecmp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/test_filecmp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/test_filecmp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@fatelei
fatelei force-pushed the cli_bas64_ut branch 2 times, most recently from f6ed21f to 9167c67 Compare October 11, 2025 14:47
picnixz
picnixz reviewed Oct 11, 2025
View reviewed changes
Comment thread Lib/test/test_filecmp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/test_filecmp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/test_filecmp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/test_filecmp.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@fatelei
fatelei force-pushed the cli_bas64_ut branch 2 times, most recently from 48afb2a to e7ade8f Compare October 11, 2025 15:44
@fatelei
chore: filecmp add unittest
9f58a3e
@fatelei
fatelei force-pushed the cli_bas64_ut branch from e7ade8f to 9f58a3e Compare October 11, 2025 15:46
@serhiy-storchaka

serhiy-storchaka commented Oct 16, 2025

Copy link
Copy Markdown
Member

This PR changes a lot of unrelated tests. Is it AI generated?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fatelei added 2 commits October 16, 2025 17:56
@fatelei
chore: update filecmp ut
09a69f6
@fatelei
fix: fix lint issue
0070322
@fatelei fatelei closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@fatelei @serhiy-storchaka @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.