GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-139958: Add TOML MIME type by gforcada · Pull Request #139959 · python/cpython

Conversation

@gforcada

@gforcada gforcada commented Oct 11, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Hi,

while doing some contributions for Plone (on Products.MimetypesRegistry distribution) I drifted away and eventually noticed that TOML files are not recognized by mimetypes module.

I followed this commit as in what to change.

Compared to the commit referenced above, I decided to skip updating Doc/whatsnew/3.15.rst as it feels way too small of a change to mention it.

Let me know if it should still be updated nonetheless.

  • Issue: TOML MIME type is missing #139958

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gforcada
gforcada requested a review from a team as a code owner October 11, 2025 15:49
@bedevere-app bedevere-app Bot mentioned this pull request Oct 11, 2025
TOML MIME type is missing #139958
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Oct 11, 2025
gforcada added 3 commits October 11, 2025 17:49
@gforcada
chore(mimetypes): keep them sorted
f15c547
@gforcada
fix(mimetypes): add toml mimetype
52a778f
@gforcada
Add change description
f5c2435
@gforcada
gforcada force-pushed the add-more-mimetypes branch from b3f4446 to f5c2435 Compare October 11, 2025 15:50
StanFromIreland
StanFromIreland reviewed Oct 11, 2025
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at previous additions, can you please add this to the What's New too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/mimetypes.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2025-10-11-17-41-26.gh-issue-139958.AnCakj.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
StanFromIreland requested a review from hugovk October 11, 2025 15:52
@gforcada @StanFromIreland
Update Misc/NEWS.d/next/Library/2025-10-11-17-41-26.gh-issue-139958.A…
f108694 
…nCakj.rst

Co-authored-by: Stan Ulbrych <[email protected]>
@hugovk
hugovk merged commit 2535345 into python:main Oct 14, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 14, 2025
@gforcada
gforcada deleted the add-more-mimetypes branch October 15, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments
@hugovk hugovk Awaiting requested review from hugovk

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gforcada @StanFromIreland @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.