GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — gh-139257: escape enumerator-like letters to support docutils 0.22 by stefanor · Pull Request #140031 · python/cpython Conversation
|
|
This feels like a Docutils bug if it requires this much escaping? A |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
That's because we have no way of disabling roman numeral handling in docutils >= 0.22, unless we specify compatible enumerator-like objects (that are implementation details in docutils and only in >= 0.22). See the issue for the commit that changed this. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Note: what would be ideal is for docutils to check first the return value of a converter, and if it is None, then assume that the conversion is disabled. That would be the cleanest way to do it (and our monkey patch would be compatible with older docutils versions) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Presumably that's what @birkenfeld thought when implementing the monkey-patch in #48813. The alternative here is to re-instate #139258 and update the monkey-patch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I added a second commit to remove the monkey-patch entirely. But instead of doing that, we could make it raise an explicit exception, to avoid accidentally introducing Roman-numbered lists. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Other FAQs use headings for the questions, which also makes them linkable: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
That would indeed be better. I think we have two distinct issues:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
We don't have a single clean method to disable roman lists across docutils versions, but we can blow up the bulid cleanly...
Docutils 0.22 does not allow referencing a link that was implicitly named earlier in the document, it complains: ERROR: Duplicate target name, cannot be used as a unique reference: "basic authentication".
Docutils 0.22 doesn't allow the contents directive to be used within an only directive, it complains: ERROR: The "contents" directive may not be used within topics or body elements.
feb1cfd to
8e6c0cc
Compare
Changed to that. Also, added a couple of additional commits for other docutils 0.22 issues. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
See PR #142056 for an alternative. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.