GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-140120: Fix memory leak in HMAC digest by ashm-dev · Pull Request #140124 · python/cpython

Conversation

@ashm-dev

@ashm-dev ashm-dev commented Oct 14, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Memory leak in hmac module with HACL* backend detected by AddressSanitizer #140120

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ashm-dev added 2 commits October 14, 2025 18:46
@ashm-dev
Fix memory leak in HMAC digest
11a7bc0
@ashm-dev
add blurb
76f110a
@ashm-dev
ashm-dev requested review from gpshead and picnixz as code owners October 14, 2025 16:00
@bedevere-app bedevere-app Bot mentioned this pull request Oct 14, 2025
Memory leak in hmac module with HACL* backend detected by AddressSanitizer #140120
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Oct 14, 2025
StanFromIreland
StanFromIreland reviewed Oct 14, 2025
View reviewed changes
Comment thread Modules/_hacl/Hacl_Streaming_HMAC.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ashm-dev @StanFromIreland
Update Modules/_hacl/Hacl_Streaming_HMAC.c
715d76c 
Co-authored-by: Stan Ulbrych <[email protected]>
@ashm-dev
ashm-dev requested a review from StanFromIreland October 14, 2025 16:15
@ZeroIntensity

ZeroIntensity commented Oct 14, 2025

Copy link
Copy Markdown
Member

Isn't this vendored code? This should probably be fixed upstream.

cc @picnixz
StanFromIreland and gpshead reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead

gpshead commented Oct 14, 2025

Copy link
Copy Markdown
Member

indeed, please report this to https://github.com/hacl-star/hacl-star and @protz or similar will help there. then we can just update our vendored version pin.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland StanFromIreland closed this Oct 14, 2025
@protz protz mentioned this pull request Oct 15, 2025
Refresh source code including memory leak fix hacl-star/hacl-star#1064
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@picnixz picnixz Awaiting requested review from picnixz picnixz is a code owner
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ashm-dev @ZeroIntensity @gpshead @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.