GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-140138: NOGIL: add atomic owner refcount to PyInterpreterState; finalize on last tstate by ashm-dev · Pull Request #140224 · python/cpython

Conversation

@ashm-dev

@ashm-dev ashm-dev commented Oct 16, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: TSAN failure with free-threaded build, test_daemon_threads_fatal_error #140138

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ashm-dev
ashm-dev requested review from ZeroIntensity and ericsnowcurrently as code owners October 16, 2025 17:02
@bedevere-app bedevere-app Bot added the awaiting review label Oct 16, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 16, 2025
TSAN failure with free-threaded build, test_daemon_threads_fatal_error #140138
Closed
@colesbury
colesbury requested a review from kumaraditya303 October 16, 2025 17:05
@ashm-dev

ashm-dev commented Oct 16, 2025

Copy link
Copy Markdown
Contributor Author

Changes made on top of the previous fix from PR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ZeroIntensity
ZeroIntensity reviewed Oct 16, 2025
View reviewed changes
Comment thread Include/internal/pycore_interp_structs.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Misc/NEWS.d/next/Core_and_Builtins/2025-10-16-20-06-33.gh-issue-140138.a_fhrh.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Python/pystate.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Python/pystate.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Python/pystate.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Python/pystate.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ashm-dev
ashm-dev requested a review from ZeroIntensity October 16, 2025 19:16
ZeroIntensity
ZeroIntensity reviewed Oct 16, 2025
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this PR looks good if we decide to fix this, but I'm worried about whether this is even a bug in the first place. See my comment on the issue. Please let me know if I missed something in my analysis.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ZeroIntensity ZeroIntensity added the DO-NOT-MERGE label Oct 17, 2025
ashm-dev added 10 commits October 19, 2025 15:10
@ashm-dev
fix tsan
115e4d2
@ashm-dev
add blurb
b58d4a1
@ashm-dev
Reorder and add _owners field
55b5fe4
Move the `_owners` field to be after `finalizing` and add it back to the
struct. It was removed in a previous commit and is needed.
@ashm-dev
Fix typo in interpreter owner atomic variable
2aba8ba
Fixes a typo where the atomic variable `_owners` was incorrectly named
and should have been `owners`.
@ashm-dev
Fix news
2690fac
@ashm-dev
Rename interpreter cleanup functions
e6ff33e
Rename functions to be more descriptive of their actions.
@ashm-dev
Refactor interpreter cleanup
47e51d7
Move the cleanup logic into PyInterpreterState_Delete and remove the
now-unused helper function.
@ashm-dev
Rename _owners to owners in interp struct
37ccb72
The field name was inconsistent with other usages.
@ashm-dev
fix
e5c1336
@ashm-dev
Stop setting interp->finalizing
d08a093
@ashm-dev
ashm-dev force-pushed the gh-140138 branch from c89c757 to d08a093 Compare October 19, 2025 12:11
@ashm-dev
Merge remote-tracking branch 'upstream/main' into pythongh-140138
5001c54
@ashm-dev

ashm-dev commented Oct 19, 2025

Copy link
Copy Markdown
Contributor Author

@ZeroIntensity this PR necessary or is it better to close it?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ZeroIntensity

ZeroIntensity commented Oct 19, 2025

Copy link
Copy Markdown
Member

I don't think this PR is necessary.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ashm-dev ashm-dev closed this Oct 19, 2025
@ashm-dev
ashm-dev deleted the gh-140138 branch October 19, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ashm-dev @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.