GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||
GeezerVison is showing github.com — gh-140138: NOGIL: add atomic owner refcount to PyInterpreterState; finalize on last tstate by ashm-dev · Pull Request #140224 · python/cpython Conversation
|
|
Changes made on top of the previous fix from PR |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this PR looks good if we decide to fix this, but I'm worried about whether this is even a bug in the first place. See my comment on the issue. Please let me know if I missed something in my analysis.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Move the `_owners` field to be after `finalizing` and add it back to the struct. It was removed in a previous commit and is needed.
Fixes a typo where the atomic variable `_owners` was incorrectly named and should have been `owners`.
Rename functions to be more descriptive of their actions.
Move the cleanup logic into PyInterpreterState_Delete and remove the now-unused helper function.
The field name was inconsistent with other usages.
|
@ZeroIntensity this PR necessary or is it better to close it? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I don't think this PR is necessary. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.