GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-140454: Remove `pyconfig.h` from Makefile `JIT_DEPS` by savannahostrowski · Pull Request #140491 · python/cpython

Conversation

@savannahostrowski

@savannahostrowski savannahostrowski commented Oct 23, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: 3.15.0a1 rewrites sysconfig-saved flags on make install #140454

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@savannahostrowski
Remove pyconfig.h from JIT_DEPS
eda50f9
@savannahostrowski
savannahostrowski requested review from AA-Turner, emmatyping and erlend-aasland as code owners October 23, 2025 04:42
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 23, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 23, 2025
3.15.0a1 rewrites sysconfig-saved flags on make install #140454
Closed
@savannahostrowski savannahostrowski added skip news and removed awaiting core review labels Oct 23, 2025
@savannahostrowski

savannahostrowski commented Oct 23, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Would be good to get a Makefile expert's eyes on this 🙏

The results of my spelunking efforts: #140454 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@savannahostrowski savannahostrowski changed the title GH-140454: Remove pyconfig.h from JIT_DEPS GH-140454: Remove pyconfig.h from Makefile JIT_DEPS Oct 23, 2025
@hroncok

hroncok commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

Thanks. I tested this, and it does not seem to solve the problem for me.

[cpython (test-jit-make-install)]$ export LDFLAGS=' '
[cpython (test-jit-make-install)]$ export LDFLAGS_NODIST='-Wl,--as-needed -g '
[cpython (test-jit-make-install)]$ git clean -fdx; ./configure --config-cache --without-ensurepip --enable-experimental-jit=yes-off && make -j...

Different shell:

[cpython (test-jit-make-install)]$ export LDFLAGS='-Wl,--as-needed -g '
[cpython (test-jit-make-install)]$ cp -a build/lib.linux-x86_64-3.15/_sysconfigdata__linux_x86_64-linux-gnu.py make._sysconfigdata__linux_x86_64-linux-gnu.py 
[cpython (test-jit-make-install %)]$ rm /tmp/python/ -rf; make install DESTDIR=/tmp/python 
[cpython (test-jit-make-install %)]$ diff -u make._sysconfigdata__linux_x86_64-linux-gnu.py build/lib.linux-x86_64-3.15/_sysconfigdata__linux_x86_64-linux-gnu.py

--- make._sysconfigdata__linux_x86_64-linux-gnu.py	2025-10-23 11:25:44.805777209 +0200
+++ build/lib.linux-x86_64-3.15/_sysconfigdata__linux_x86_64-linux-gnu.py	2025-10-23 11:25:59.599337788 +0200
@@ -19,7 +19,7 @@
     'BINDIR': '/usr/local/bin',
     'BINLIBDEST': '/usr/local/lib/python3.15',
     'BLDLIBRARY': 'libpython3.15.a',
-    'BLDSHARED': 'gcc -shared',
+    'BLDSHARED': 'gcc -shared -Wl,--as-needed -g',
     'BOOTSTRAP_HEADERS': '\\',
     'BUILDEXE': '',
     'BUILDPYTHON': 'python',
@@ -647,11 +647,12 @@
     'IO_OBJS': '\\',
     'IPHONEOS_DEPLOYMENT_TARGET': '',
     'JIT_DEPS': '\\',
-    'LDCXXSHARED': 'g++ -shared',
-    'LDFLAGS': '',
+    'LDCXXSHARED': 'g++ -shared -Wl,--as-needed -g',
+    'LDFLAGS': '-Wl,--as-needed -g',
+    'LDFLAGS_NODIST': '',
     'LDLIBRARY': 'libpython3.15.a',
     'LDLIBRARYDIR': '',
-    'LDSHARED': 'gcc -shared',
+    'LDSHARED': 'gcc -shared -Wl,--as-needed -g',
     'LDVERSION': '3.15',
     'LIBC': '',
     'LIBDEST': '/usr/local/lib/python3.15',
@@ -987,8 +988,8 @@
     'PY_CPPFLAGS': '-I. -I./Include',
     'PY_ENABLE_SHARED': 0,
     'PY_HAVE_PERF_TRAMPOLINE': 1,
-    'PY_LDFLAGS': '',
-    'PY_LDFLAGS_NODIST': '-Wl,--as-needed -g -Wl,--as-needed -g',
+    'PY_LDFLAGS': '-Wl,--as-needed -g',
+    'PY_LDFLAGS_NODIST': '-Wl,--as-needed -g',
     'PY_LDFLAGS_NOLTO': '-Wl,--as-needed -g',
     'PY_SQLITE_ENABLE_LOAD_EXTENSION': 0,
     'PY_SQLITE_HAVE_SERIALIZE': 0,
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@savannahostrowski

savannahostrowski commented Oct 23, 2025

Copy link
Copy Markdown
Member Author

Wow, okay. I cannot reproduce this either locally or in a Fedora Devcontainer with the steps you've outlined above. I'll close this PR for now, and we can take the discussion back into the issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@savannahostrowski savannahostrowski closed this Oct 23, 2025
@savannahostrowski
savannahostrowski deleted the test-jit-make-install branch December 4, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@savannahostrowski @hroncok
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.