GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-139871: Add _PyByteArray_empty_string to the stable ABI by vstinner · Pull Request #140770 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 29, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add .take_bytes([n]) a zero-copy path from bytearray to bytes #139871

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-139871: Add _PyByteArray_empty_string to the stable ABI
cea1297
@vstinner
vstinner requested a review from a team as a code owner October 29, 2025 19:37
@vstinner vstinner added the skip news label Oct 29, 2025
@vstinner
vstinner requested a review from encukou as a code owner October 29, 2025 19:37
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 29, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 29, 2025
Add .take_bytes([n]) a zero-copy path from bytearray to bytes #139871
Closed
@vstinner

vstinner commented Oct 29, 2025

Copy link
Copy Markdown
Member Author

#140128 tried to remove _PyByteArray_empty_string by mistake which would break the stable ABI. Let's put it in the stable ABI to detect if it's removed by mistake.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Oct 29, 2025
gh-139871: Add bytearray.take_bytes([n]) to efficiently extract bytes #140128
Merged
@encukou

encukou commented Oct 30, 2025

Copy link
Copy Markdown
Member

It's not part of the stable ABI; it's certainly not in the Windows stable ABI DLL.
Let's not add it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 30, 2025

Copy link
Copy Markdown
Member Author

Oh, it's declared in Include/cpython/bytearrayobject.h, not in Include/bytearrayobject.h, you're right.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Oct 30, 2025
@vstinner
vstinner deleted the ba_empty_string branch October 30, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou Awaiting requested review from encukou encukou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.