GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-141174: Improve `annotationlib.get_annotations()` test coverage (GH-141286) by miss-islington · Pull Request #141353 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 10, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

  • Test get_annotations(format=Format.VALUE) for stringized annotations on custom objects

  • Test get_annotations(format=Format.VALUE) for stringized annotations on wrapped partial functions

  • Update test_stringized_annotations_with_star_unpack() to actually test stringized annotations

  • Test annotate returning a non-dict

  • Test passing globals and locals to stringized get_annotations()
    (cherry picked from commit 06b6228)

Co-authored-by: dr-carlos [email protected]

  • Issue: annotationlib: Improve test coverage #141174

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dr-carlos @miss-islington
pythongh-141174: Improve annotationlib.get_annotations() test cover…
520480e 
…age (pythonGH-141286)

* Test `get_annotations(format=Format.VALUE)` for stringized annotations on custom objects

* Test `get_annotations(format=Format.VALUE)` for stringized annotations on wrapped partial functions

* Update test_stringized_annotations_with_star_unpack() to actually test stringized annotations

* Test __annotate__ returning a non-dict

* Test passing globals and locals to stringized `get_annotations()`
(cherry picked from commit 06b6228)

Co-authored-by: dr-carlos <[email protected]>
@miss-islington
miss-islington requested a review from JelleZijlstra as a code owner November 10, 2025 14:45
@bedevere-app bedevere-app Bot added the skip news label Nov 10, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 10, 2025
gh-141174: Improve annotationlib.get_annotations() test coverage #141286
Merged
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Nov 10, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 10, 2025
annotationlib: Improve test coverage #141174
Closed
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) November 10, 2025 14:46
@JelleZijlstra
JelleZijlstra merged commit 9221030 into python:3.14 Nov 10, 2025
51 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Nov 10, 2025
@miss-islington
miss-islington deleted the backport-06b6228-3.14 branch January 2, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @JelleZijlstra @dr-carlos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.