GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] GH-139914: Handle stack growth direction on HPPA (GH-140028) by stefanor · Pull Request #141404 · python/cpython

Conversation

@stefanor

@stefanor stefanor commented Nov 11, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adapted from a patch for Python 3.14 submitted to the Debian BTS by John David Anglin https://bugs.debian.org/1105111#20

  • Issue: Python 3.14 fails to build on hppa, error indicates stack overflow (false positive?) #139914

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@stefanor
stefanor requested review from corona10, ericsnowcurrently, erlend-aasland and markshannon as code owners November 11, 2025 14:33
@bedevere-app bedevere-app Bot added the awaiting review label Nov 11, 2025
This was referenced Nov 11, 2025
GH-139914: Handle stack growth direction on HPPA #140028
Merged
Python 3.14 fails to build on hppa, error indicates stack overflow (false positive?) #139914
Closed
@stefanor
[3.14] pythonGH-139914: Handle stack growth direction on HPPA (python…
bdcc6e3 
…GH-140028)

Adapted from a patch for Python 3.14 submitted to the Debian BTS by John David Anglin https://bugs.debian.org/1105111#20
@stefanor
stefanor force-pushed the hppa-stack-3.14 branch from 7635f19 to bdcc6e3 Compare November 11, 2025 14:35
@StanFromIreland StanFromIreland added the DO-NOT-MERGE label Nov 11, 2025
@StanFromIreland

StanFromIreland commented Nov 11, 2025

Copy link
Copy Markdown
Member

Marking as DO-NOT-MERGE as the main PR has not yet been merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stefanor
Forgot to update test_call
81cc54b
@stefanor

stefanor commented Nov 17, 2025

Copy link
Copy Markdown
Contributor Author

This is now mergeable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland StanFromIreland removed the DO-NOT-MERGE label Nov 17, 2025
@StanFromIreland
StanFromIreland requested a review from encukou November 17, 2025 16:26
StanFromIreland
StanFromIreland reviewed Nov 17, 2025
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the warning causing the CI to fail: https://github.com/python/cpython/actions/runs/19303215688/job/55203254605?pr=141404

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@stefanor
WTF typo
a26fcc3
@stefanor

stefanor commented Nov 17, 2025

Copy link
Copy Markdown
Contributor Author

Err, how on earth did that ever compile? Testing again...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stefanor

stefanor commented Nov 18, 2025

Copy link
Copy Markdown
Contributor Author

Yeah, looks fine.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou added the release-blocker label Nov 19, 2025
@github-project-automation github-project-automation Bot added this to Release and Deferred blockers 🚫 Nov 19, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Release and Deferred blockers 🚫 Nov 19, 2025
encukou
encukou approved these changes Nov 20, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 20, 2025
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 20, 2025
@bedevere-bot

bedevere-bot commented Nov 20, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit a26fcc3 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141404%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 20, 2025
@hugovk

hugovk commented Nov 23, 2025

Copy link
Copy Markdown
Member

Buildbots have passed.

"buildbot/iOS ARM64 Simulator PR" shows as "Waiting for status to be reported — Build started" but has completed and passed at https://buildbot.python.org/#/builders/1382/builds/739.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead
gpshead approved these changes Nov 23, 2025
View reviewed changes
@gpshead
gpshead merged commit 394db66 into python:3.14 Nov 23, 2025
130 of 131 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@github-project-automation github-project-automation Bot moved this from Todo to Done in Release and Deferred blockers 🚫 Nov 23, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 23, 2025
@stefanor
stefanor deleted the hppa-stack-3.14 branch November 24, 2025 12:50
@vstinner vstinner mentioned this pull request Nov 24, 2025
[3.14] gh-139653: Add PyUnstable_ThreadState_SetStackProtection() (GH-139668) #141661
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments
@gpshead gpshead gpshead approved these changes
@encukou encukou encukou approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

release-blocker

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@stefanor @StanFromIreland @bedevere-bot @hugovk @gpshead @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.