GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-140104: Set next_instr properly in the JIT during exceptions (GH-140233) by efimov-mikhail · Pull Request #141495 · python/cpython

Conversation

@efimov-mikhail

@efimov-mikhail efimov-mikhail commented Nov 13, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It's an another attempt to backport GH-140233.
The first one was buggy and we reverted it.

CC @Fidget-Spinner.

I'm not sure that this fix is fully correct.
But it passes all the tests on my machine (Debian 12, x86_64) in both build configurations:

./configure --enable-experimental-jit=yes --with-pydebug
./configure --enable-experimental-jit=interpreter --with-pydebug
  • Issue: JIT (correctness): Different UnboundLocalError for same code with JIT on or off #140104

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@efimov-mikhail
Backport
d63997e
@efimov-mikhail
efimov-mikhail requested a review from markshannon as a code owner November 13, 2025 09:54
@bedevere-app bedevere-app Bot added the awaiting review label Nov 13, 2025
@efimov-mikhail
efimov-mikhail requested review from Fidget-Spinner and removed request for markshannon November 13, 2025 09:54
This was referenced Nov 13, 2025
gh-140104: Set next_instr properly in the JIT during exceptions #140233
Merged
JIT (correctness): Different UnboundLocalError for same code with JIT on or off #140104
Closed
Fidget-Spinner
Fidget-Spinner reviewed Nov 13, 2025
View reviewed changes
Comment thread Python/ceval_macros.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@efimov-mikhail
Simplify GOTO_TIER_ONE
830cfbe
Fidget-Spinner
Fidget-Spinner reviewed Nov 13, 2025
View reviewed changes
Comment thread Python/ceval_macros.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@python python deleted a comment from Fidget-Spinner Nov 13, 2025
@Fidget-Spinner

Fidget-Spinner commented Nov 13, 2025

Copy link
Copy Markdown
Member

Could you pleas trigger the JIT CI by pushing whitespace to a jit file? We can revert that after I see it's green.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@efimov-mikhail
Trigger CI
c3442cd
@efimov-mikhail
efimov-mikhail requested review from brandtbucher and savannahostrowski as code owners November 13, 2025 15:31
@efimov-mikhail
efimov-mikhail removed request for brandtbucher and savannahostrowski November 13, 2025 15:31
@efimov-mikhail
Trigger JIT CI
b196616
@efimov-mikhail

efimov-mikhail commented Nov 13, 2025

Copy link
Copy Markdown
Member Author

Could you pleas trigger the JIT CI by pushing whitespace to a jit file? We can revert that after I see it's green.

Sure! I hope that I understand correctly what file do you mean (Tools/jit/template.c).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner

Fidget-Spinner commented Nov 13, 2025

Copy link
Copy Markdown
Member

Very cool. It's green! Ok, please revert the jit file change and I'll merge it.
efimov-mikhail reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
efimov-mikhail added 2 commits November 13, 2025 19:13
@efimov-mikhail
Revert JIT file temporary change
781dbda
@efimov-mikhail
Merge branch '3.14' into Fidget-Spinner-this_instr_exception-3.14-2
77e10f0
Fidget-Spinner
Fidget-Spinner approved these changes Nov 13, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 13, 2025
@Fidget-Spinner

Fidget-Spinner commented Nov 13, 2025

Copy link
Copy Markdown
Member

Thanks again.
efimov-mikhail reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Fidget-Spinner merged commit af20b88 into python:3.14 Nov 13, 2025
57 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 13, 2025
@efimov-mikhail

efimov-mikhail commented Nov 13, 2025

Copy link
Copy Markdown
Member Author

Thank you for review and merge!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@efimov-mikhail @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.