GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-140601: Refactor ElementTree.iterparse() tests (GH-141499) by miss-islington · Pull Request #141502 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 13, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Split existing tests on smaller methods and move them to separate class.
Rename variable "content" to "it".
Use BytesIO instead of StringIO.
Add few more tests.
(cherry picked from commit 2fbd396)

Co-authored-by: Serhiy Storchaka [email protected]

  • Issue: xml.etree.ElementTree.iterparse() should emit ResourceWarning when not explicitly closed #140601

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka @miss-islington
pythongh-140601: Refactor ElementTree.iterparse() tests (pythonGH-141499
75c5add
)

Split existing tests on smaller methods and move them to separate class.
Rename variable "content" to "it".
Use BytesIO instead of StringIO.
Add few more tests.
(cherry picked from commit 2fbd396)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app Bot added the skip news label Nov 13, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 13, 2025
gh-140601: Refactor ElementTree.iterparse() tests #141499
Merged
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Nov 13, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 13, 2025
xml.etree.ElementTree.iterparse() should emit ResourceWarning when not explicitly closed #140601
Closed
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) November 13, 2025 11:49
@serhiy-storchaka
serhiy-storchaka merged commit 7b8c257 into python:3.14 Nov 13, 2025
51 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting review label Nov 13, 2025
@miss-islington
miss-islington deleted the backport-2fbd396-3.14 branch January 2, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.