GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-44968: Add "Reload from Disk" feature to IDLE by ashm-dev · Pull Request #141574 · python/cpython

Conversation

ashm-dev commented Nov 14, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Issue: IDLE: Add File - Reload #44968

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-44968: Add "Reload from Disk" feature to IDLE

39e6187

ashm-dev requested a review from terryjreedy as a code owner

November 14, 2025 22:02

bedevere-app Bot added the awaiting review label

Nov 14, 2025

bedevere-app Bot mentioned this pull request

Nov 14, 2025

IDLE: Add File - Reload #44968

Open


          Use builtins.open for file operations in tests

9dacd3d

sharktide reviewed

Nov 15, 2025

View reviewed changes

Comment thread

Lib/idlelib/iomenu.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

sharktide reviewed

Nov 15, 2025

View reviewed changes

sharktide left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don’t think we should restore the cursor position since a file’s line numbers could also change when it is edited and it could cause confusion.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ashm-dev and others added 2 commits

November 15, 2025 09:47


          Update Lib/idlelib/iomenu.py

884758b

Co-authored-by: R.C.M <[email protected]>


          Simplify file reload by removing cursor restoration

d6f54a2

Removed cursor position restoration logic during file reload.

ashm-dev commented Nov 15, 2025

Copy link

Copy Markdown

Contributor Author

I also don’t think we should restore the cursor position since a file’s line numbers could also change when it is edited and it could cause confusion.

Rewrote it, now it won't save cursor position.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'main' into idle

66ab8ce

ashm-dev requested a review from sharktide

November 15, 2025 07:24

ashm-dev added 2 commits

November 15, 2025 10:38


          Fix typo in 'File Not Found' message

c10c5b9


          Update error message in test for file reload

7a88c34

picnixz previously requested changes

Nov 15, 2025

View reviewed changes

picnixz left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rely more on unittest.mock.patch() as well as mock features directly. In addition add a What's New entry in addition to the NEWS entry.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sharktide reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

Lib/idlelib/idle_test/test_iomenu.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/idlelib/idle_test/test_iomenu.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/idlelib/idle_test/test_iomenu.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/idlelib/idle_test/test_iomenu.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/idlelib/idle_test/test_iomenu.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/idlelib/idle_test/test_iomenu.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting review label

Nov 15, 2025

bedevere-app Bot commented Nov 15, 2025

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added the awaiting changes label

Nov 15, 2025

ashm-dev added 8 commits

November 15, 2025 23:30


          fix import

5614c28


          Merge remote-tracking branch 'origin/idle' into idle

3ce95d3


          fix: move local imports to global

545ba86


          test_iomenu: use unittest.mock.patch and call_args

5f5e769


          IDLE tests: use addCleanup for tempfile removal in test_iomenu

da37468


          remove comments

66e0495


          refactor(tests): Use mock.patch for messagebox dialogs

a154c9f


          add news

bd28bb4

ashm-dev requested a review from AA-Turner as a code owner

November 15, 2025 22:28


          rewrite tests

fe997ec

ashm-dev commented Nov 15, 2025

Copy link

Copy Markdown

Contributor Author

I have made the requested changes; please review again

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting changes label

Nov 15, 2025

ashm-dev requested review from a team, 1st1, JelleZijlstra, ZeroIntensity, abalkin, ambv, asvetlov, brettcannon, corona10, emmatyping, encukou, ericsnowcurrently, erlend-aasland, ezio-melotti, freakboy3742, gaogaotiantian, hugovk, kumaraditya303, lysnikolaou, markshannon, ncoghlan, pablogsal, pganssle, rhettinger, savannahostrowski, warsaw and willingc as code owners

December 8, 2025 15:58

python-cla-bot Bot commented Dec 8, 2025

Copy link

Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

[email protected]

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ashm-dev closed this

Dec 8, 2025

ashm-dev deleted the idle branch

December 8, 2025 16:00

Reviewers

picnixz

picnixz requested changes

terryjreedy

Awaiting requested review from terryjreedy

terryjreedy is a code owner

AA-Turner

Awaiting requested review from AA-Turner

AA-Turner is a code owner

gpshead

Awaiting requested review from gpshead

gpshead is a code owner

berkerpeksag

Awaiting requested review from berkerpeksag

erlend-aasland

Awaiting requested review from erlend-aasland

erlend-aasland is a code owner

pablogsal

Awaiting requested review from pablogsal

pablogsal is a code owner

lysnikolaou

Awaiting requested review from lysnikolaou

lysnikolaou is a code owner

ambv

Awaiting requested review from ambv

ambv is a code owner

gaogaotiantian

Awaiting requested review from gaogaotiantian

gaogaotiantian is a code owner

ezio-melotti

Awaiting requested review from ezio-melotti

ezio-melotti is a code owner

rhettinger

Awaiting requested review from rhettinger

rhettinger is a code owner

pganssle

Awaiting requested review from pganssle

pganssle is a code owner

abalkin

Awaiting requested review from abalkin

hugovk

Awaiting requested review from hugovk

hugovk is a code owner

1st1

Awaiting requested review from 1st1

1st1 is a code owner

asvetlov

Awaiting requested review from asvetlov

asvetlov is a code owner

kumaraditya303

Awaiting requested review from kumaraditya303

kumaraditya303 is a code owner

willingc

Awaiting requested review from willingc

willingc is a code owner

savannahostrowski

Awaiting requested review from savannahostrowski

savannahostrowski is a code owner

JelleZijlstra

Awaiting requested review from JelleZijlstra

JelleZijlstra is a code owner

ericsnowcurrently

Awaiting requested review from ericsnowcurrently

ericsnowcurrently is a code owner

brettcannon

Awaiting requested review from brettcannon

brettcannon is a code owner

ncoghlan

Awaiting requested review from ncoghlan

ncoghlan is a code owner

warsaw

Awaiting requested review from warsaw

warsaw is a code owner

markshannon

Awaiting requested review from markshannon

markshannon is a code owner

ZeroIntensity

Awaiting requested review from ZeroIntensity

ZeroIntensity is a code owner

emmatyping

Awaiting requested review from emmatyping

emmatyping is a code owner

freakboy3742

Awaiting requested review from freakboy3742

encukou

Awaiting requested review from encukou

encukou is a code owner

corona10

Awaiting requested review from corona10

corona10 is a code owner

+1 more reviewer

sharktide

sharktide left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ashm-dev commented Nov 14, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sharktide left a comment

Choose a reason for hiding this comment

Uh oh!

ashm-dev commented Nov 15, 2025

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-app Bot commented Nov 15, 2025

Uh oh!

ashm-dev commented Nov 15, 2025

Uh oh!

python-cla-bot Bot commented Dec 8, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

ashm-dev commented Nov 14, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.