GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — gh-141594: A free-threaded JIT (Part 1) by Fidget-Spinner · Pull Request #141595 · python/cpython Conversation
|
|
@sergey-miryanov in the future could you please bundle up your reviews and send them in one review instead of multiple reviews? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Latest results for macOS FT+JIT are incredibly good: 8-10% faster on pyperformance versus just FT-only. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Not an expert in this area, but everything looks reasonable. I just have a couple of comments/questions as usual :)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
| // There's more than one thread. In FT mode, | ||
| // disable the JIT completely for now. |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's feasible to add a test that ensures the JIT is properly disabled and then re-enabled?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I added a test, thanks!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This PR is stale because it has been open for 90 days with no activity. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.