GeezerVison is showing github.com — gh-91242: [cleanup] Remove the unsupported windows CHM help doc build system by gpshead · Pull Request #141643 · python/cpython
Conversation
gpshead
commented
Nov 16, 2025
•
edited by github-actions
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
This originally started by having claude look for easy TODOs to tackle and seeing idlelib.editor._sphinx_version() as unneeded. which led to the rabbithole of "what windows chm build stuff is left to cleanup" and finding all of this.
I explicitly asked claude to keep the htmlhelp build target and focus only on removing the CHM support. As I have no idea who and what may still use the claimed useful on all platforms htmlhelp itself.
But the long dead/deprecated by Microsoft CHM format stuff can still go away? I need both Windows and Docs folks take on this. The linked issue kickstarted its deprecation and removal from our installers in 2022, but I also don't touch windows so I'm the wrong one to ask.
🤖 Commits generated with Claude Code
📚 Documentation preview 📚: https://cpython-previews--141643.org.readthedocs.build/
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The `_sphinx_version()` function is no longer needed since CHM
(Compiled HTML Help) documentation files are no longer installed.
This removes the dead code as indicated by the TODO comment.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Remove all CHM compilation infrastructure to complete the deprecation
that began in August 2022. CHM format documentation is now obsolete
and has been replaced by HTML documentation.
Changes:
- Doc/: Remove CHM compilation from make.bat, remove htmlhelp config
from conf.py, update Makefile and README.rst to remove CHM references
- PC/layout/: Remove CHM file copying, constants, options, and manifest
entries from the Windows package layout system
- Tools/msi/: Remove CHM support from MSI installer build and upload
scripts
The htmlhelp build target is retained as it remains useful for
generating HTML Help format files without CHM compilation.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
gpshead reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Remove PDF and CHM references from IDLE help file browser and config.
Co-Authored-By: Claude <[email protected]>
|
I'd prefer to leave the PC/layout scripts unchanged, as those are version-independent (you can use main to lay out/package older builds), and the Tools/msi scripts are also deprecated to be removed after 3.15, so probably safer to leave those alone as well.
It looks like the Doc changes still allow us to generate htmlhelp, it just results in HTML files (like html)? Is there any value to this? I know we had to do some tricks with encoding and (IIRC) cross-references for HTMLHelp, so maybe those are still relevant?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
This PR is stale because it has been open for 30 days with no activity.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|