GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-140774: Fix pathlib.Path.chmod handling of Windows Archive bit by pareshjoshij · Pull Request #142018 · python/cpython

Conversation

@pareshjoshij

@pareshjoshij pareshjoshij commented Nov 27, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #140774.

On Windows, Path.chmod(mode, follow_symlinks=True) fails silently (does not change permissions) if the target file has its Archive bit cleared. This issue arises because passing a Path object directly to os.chmod triggers a behavior difference in the Windows implementation compared to passing a raw string.

The Fix:
Updated Lib/pathlib/__init__.py to explicitly cast the path to a string (str(self)) before passing it to os.chmod.

Verification:
Added a regression test test_chmod_archive_bit_behavior to WindowsPathTest in Lib/test/test_pathlib/test_pathlib.py. The test:

  1. Creates a temporary file.
  2. Manually clears the Archive bit using the Windows attrib command.
  3. Verifies that chmod successfully removes the Read-Only attribute.
  • Issue: Path.chmod() silently fails on Windows when archive bit is cleared and follow_symlinks=True #140774

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pareshjoshij
pythongh-140774: Fix pathlib.Path.chmod not handling the Archive bit …
9cf6cd7 
…on Windows
@pareshjoshij
pareshjoshij requested a review from barneygale as a code owner November 27, 2025 16:20
@bedevere-app bedevere-app Bot added the awaiting review label Nov 27, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 27, 2025
Path.chmod() silently fails on Windows when archive bit is cleared and follow_symlinks=True #140774
Closed
@pareshjoshij
pareshjoshij marked this pull request as draft November 27, 2025 16:38
@bedevere-app bedevere-app Bot removed the awaiting review label Nov 27, 2025
pareshjoshij added 3 commits November 28, 2025 11:56
@pareshjoshij
Fix pythongh-140774: os.chmod fails to clear Read-Only if Archive bit…
25cc0a2 
… is cleared
@pareshjoshij
Remove unused subprocess import in WindowsPathTest
dd0cd0e 
Removed unused import of subprocess in WindowsPathTest.
@pareshjoshij
Fix indentation in posixmodule.c
c8a5999
@pareshjoshij pareshjoshij closed this Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barneygale barneygale Awaiting requested review from barneygale barneygale is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Path.chmod() silently fails on Windows when archive bit is cleared and follow_symlinks=True

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@pareshjoshij
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.