GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make RESUME monitoring more readable and robust by P403n1x87 · Pull Request #142136 · python/cpython

Conversation

@P403n1x87

@P403n1x87 P403n1x87 commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

We make the code for the monitoring of PY_START and PY_RESUME events triggered by the RESUME opcode more readable and maintainable by not relying on some obscure logic on the value of oparg that can easily break if the event IDs are ever changed in the future.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@P403n1x87
Make RESUME monitoring more readable and robust
59506ca
We make the code for the monitoring of PY_START and PY_RESUME events
triggered by the RESUME opcode more readable and maintainable by
not relying on some obscure logic on the value of oparg that can
easily break if the event IDs are ever changed in the future.
@P403n1x87
P403n1x87 requested a review from markshannon as a code owner December 1, 2025 15:00
@bedevere-app bedevere-app Bot added the awaiting review label Dec 1, 2025
@P403n1x87
add regen result
cff2132
@markshannon markshannon added skip issue skip news labels Dec 1, 2025
markshannon
markshannon approved these changes Dec 1, 2025
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That's a lot more readable.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 1, 2025
@P403n1x87 P403n1x87 mentioned this pull request Dec 5, 2025
Make the PY_UNWIND monitoring event local #142186
Closed
@P403n1x87
Merge branch 'main' into start-resume-events-coded-properly
984f795
@python-cla-bot

python-cla-bot Bot commented Dec 16, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon

markshannon commented Dec 16, 2025

Copy link
Copy Markdown
Member

@P403n1x87 you'll need to sign the CLA before I can merge this.
Or set your email address properly in the merge commit?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@P403n1x87

P403n1x87 commented Dec 16, 2025

Copy link
Copy Markdown
Contributor Author

@P403n1x87 you'll need to sign the CLA before I can merge this.

Ah it looks like I signed the (now legacy) one in 2021. Signed the new CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon
markshannon merged commit 16a305f into python:main Dec 16, 2025
68 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@P403n1x87 @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.