GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-141004: Add a CI job ensuring that new C APIs include documentation (GH-142102) by ZeroIntensity · Pull Request #142248 · python/cpython

Conversation

@ZeroIntensity

@ZeroIntensity ZeroIntensity commented Dec 4, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 1a7824a)

  • Issue: Document the entire C API #141004

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ZeroIntensity and others added 2 commits December 3, 2025 22:58
@ZeroIntensity @hugovk
pythongh-141004: Add a CI job ensuring that new C APIs include docume…
aa0d658 
…ntation (pythonGH-142102)

Co-authored-by: Hugo van Kemenade <[email protected]>
(cherry picked from commit 1a7824a)
@ZeroIntensity @hugovk
[3.13] pythongh-141004: Add a CI job ensuring that new C APIs include…
9345940 
… documentation (pythonGH-142102)

(cherry picked from commit 1a7824a)

Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@ZeroIntensity
ZeroIntensity requested review from ezio-melotti and hugovk as code owners December 4, 2025 03:58
This was referenced Dec 4, 2025
Document the entire C API #141004
Closed
gh-141004: Add a CI job ensuring that new C APIs include documentation #142102
Merged
@bedevere-app bedevere-app Bot added skip news awaiting core review labels Dec 4, 2025
@ZeroIntensity

ZeroIntensity commented Dec 4, 2025

Copy link
Copy Markdown
Member Author

See #142247 (comment).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity
ZeroIntensity marked this pull request as draft December 4, 2025 04:06
@bedevere-app bedevere-app Bot removed the awaiting core review label Dec 4, 2025
@ZeroIntensity

ZeroIntensity commented Dec 4, 2025

Copy link
Copy Markdown
Member Author

@hugovk Quick question -- it seems CI on 3.13 uses Python 3.12, not 3.13. Is that intentional? If so, I need to remove the use of _colorize here on 3.13.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Dec 8, 2025

Copy link
Copy Markdown
Member

Hmm, well we're installing 3.x in this job, which right now is 3.14:

https://github.com/ZeroIntensity/cpython/blob/backport-1a7824a-3.13/.github/workflows/build.yml#L152-L154

However, for the 3.14 branch, when we run configure:

https://github.com/ZeroIntensity/cpython/blob/93459405c92cb5d275bf310b1d5d1dc43967cfdc/.github/workflows/build.yml#L164

We get:

checking for python3.14... python3.14
checking Python for regen version... Python 3.14.0

But on this 3.13 branch, for some reason we get:

checking for python3.13... no
checking for python3.13... no
checking for python3.12... python3.12
checking Python for regen version... Python 3.12.3

I'm not sure why configure is selecting 3.12...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity

ZeroIntensity commented Dec 9, 2025

Copy link
Copy Markdown
Member Author

Do you know if the configure script on 3.13 checks for 3.14? I think that might be the problem. I'm guessing that Python 3.12 is already installed on the system the CI job is running on, and actions/setup-python installs 3.14, which isn't detected by the configure script, so it falls back to 3.12.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Dec 9, 2025

Copy link
Copy Markdown
Member

Do you know if the configure script on 3.13 checks for 3.14?

No, it only checks the current version and lower.

main:

cpython/configure

Line 3828 in 756e7d1

for ac_prog in python$PACKAGE_VERSION python3.15 python3.14 python3.13 python3.12 python3.11 python3.10 python3 python

3.14:

cpython/configure

Line 3820 in f200776

for ac_prog in python$PACKAGE_VERSION python3.15 python3.14 python3.13 python3.12 python3.11 python3.10 python3 python

3.13:

cpython/configure

Line 3765 in b57d695

for ac_prog in python$PACKAGE_VERSION python3.13 python3.12 python3.11 python3.10 python3 python

I think that might be the problem. I'm guessing that Python 3.12 is already installed on the system the CI job is running on, and actions/setup-python installs 3.14, which isn't detected by the configure script, so it falls back to 3.12.

Yes, that indeed looks like the problem.

Here's a test workflow that installs a give version, then tries to check for them all:

          python3.15 --version --version || true
          python3.14 --version --version || true
          python3.13 --version --version || true
          python3.12 --version --version || true
          python3.11 --version --version || true
          python3.10 --version --version || true

And they all have the given version, plus 3.12. For example with 3.15:

Python 3.15.0a2 (main, Nov 19 2025, 15:10:47) [GCC 13.3.0]
/home/runner/work/_temp/9872e36d-a21e-4c3e-8aa1-e6d8f6781c42.sh: line 2: python3.14: command not found
/home/runner/work/_temp/9872e36d-a21e-4c3e-8aa1-e6d8f6781c42.sh: line 3: python3.13: command not found
Python 3.12.3 (main, Nov  6 2025, 13:44:16) [GCC 13.3.0]
/home/runner/work/_temp/9872e36d-a21e-4c3e-8aa1-e6d8f6781c42.sh: line 5: python3.11: command not found
/home/runner/work/_temp/9872e36d-a21e-4c3e-8aa1-e6d8f6781c42.sh: line 6: python3.10: command not found

And it's an old 3.12.3 baked into the image, because when we specifically ask for 3.12 we get the newest 3.12.12:

/home/runner/work/_temp/5205e491-dc12-4355-bc92-e4fd7a15bf8a.sh: line 1: python3.15: command not found
/home/runner/work/_temp/5205e491-dc12-4355-bc92-e4fd7a15bf8a.sh: line 2: python3.14: command not found
/home/runner/work/_temp/5205e491-dc12-4355-bc92-e4fd7a15bf8a.sh: line 3: python3.13: command not found
Python 3.12.12 (main, Oct 10 2025, 01:01:16) [GCC 13.3.0]
/home/runner/work/_temp/5205e491-dc12-4355-bc92-e4fd7a15bf8a.sh: line 5: python3.11: command not found
/home/runner/work/_temp/5205e491-dc12-4355-bc92-e4fd7a15bf8a.sh: line 6: python3.10: command not found
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity ZeroIntensity mentioned this pull request Dec 9, 2025
3.13 CI uses 3.12 for generation scripts #142457
Closed
@ZeroIntensity

ZeroIntensity commented Dec 9, 2025

Copy link
Copy Markdown
Member Author

Thanks, I created an issue: #142457
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity
Merge branch '3.13' into backport-1a7824a-3.13
643ac9c
ZeroIntensity
ZeroIntensity commented Dec 15, 2025
View reviewed changes
Comment thread Tools/check-c-api-docs/ignored_c_api.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity
Update Tools/check-c-api-docs/ignored_c_api.txt
ee91f10
@ZeroIntensity
ZeroIntensity marked this pull request as ready for review December 15, 2025 02:42
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 15, 2025
@ZeroIntensity
ZeroIntensity merged commit 5569ffe into python:3.13 Dec 15, 2025
40 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity
ZeroIntensity deleted the backport-1a7824a-3.13 branch December 15, 2025 03:19
@bedevere-app bedevere-app Bot removed the awaiting core review label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ZeroIntensity @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.