GeezerVison is showing github.com — gh-141786: Fix missing parent executor during JIT of trace by caje731 · Pull Request #142286 · python/cpython
Conversation
caje731
commented
Dec 5, 2025
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
All commit authors signed the Contributor License Agreement.

|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
picnixz
commented
Dec 5, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
It is customary to ask on the issue if one can create a PR for the patch before doing it, especially if someone is already assigned to the issue. If the assignee has already started working on it, it should be done so to avoid synchronization issues. Sorry, but I will close the PR for now (in addition, tests seem to be broken by this change) (you can still work on it on your fork but we try to avoid open PRs sitting there).
If the assignee wants to delegate the work, I'll re-open the PR (but the tests need to pass, and regression tests must be added as well)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
The check in crval.c is wrong.
You need to move the following checks into this line. So it should be a nested if.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@picnixz I'm helping the OP with creating a PR for this. So I let them take the issue.
|
picnixz reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
markshannon
Awaiting requested review from markshannon
markshannon will be requested when the pull request is marked ready for review
markshannon is a code owner
Fidget-Spinner
Awaiting requested review from Fidget-Spinner
Fidget-Spinner will be requested when the pull request is marked ready for review
Fidget-Spinner is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.