GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-141658: JIT: lazy executor flush while the world is stopped by maurycy · Pull Request #142329 · python/cpython

Conversation

@maurycy

@maurycy maurycy commented Dec 6, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

See #141658 for more details.

The problem I'm having here is reproducing this reliably.

  • Issue: JIT executor invalidation is called in unsafe ways which may deadlock #141658

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@maurycy
jit: lazy executor flush while the world stopped
242ddf4
@maurycy
maurycy requested review from ZeroIntensity, ericsnowcurrently and markshannon as code owners December 6, 2025 00:22
@bedevere-app bedevere-app Bot added the awaiting review label Dec 6, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 6, 2025
JIT executor invalidation is called in unsafe ways which may deadlock #141658
Closed
@maurycy
blurb
48f6b6b
@maurycy

maurycy commented Dec 6, 2025

Copy link
Copy Markdown
Contributor Author

cc @Fidget-Spinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner

Fidget-Spinner commented Dec 6, 2025

Copy link
Copy Markdown
Member

You could try reducing the capacity of the list and run it with instrumentation code to see if a deadlock happens?

Otherwise this is very unlikely to happen, but it's still good we fix it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner
Fidget-Spinner reviewed Dec 6, 2025
View reviewed changes
Comment thread Python/optimizer.c
return 0;
}
#endif
return 1;

@Fidget-Spinner Fidget-Spinner Dec 6, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? It's still not safe even with the GIL.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Python/optimizer.c
can_clear_executor_deletion_list(PyInterpreterState *interp)
{
#ifdef Py_GIL_DISABLED
if (_PyRuntime.stoptheworld.world_stopped || interp->stoptheworld.world_stopped) {

@Fidget-Spinner Fidget-Spinner Dec 6, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need FT atomic reads here?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@maurycy
maurycy marked this pull request as draft December 8, 2025 14:25
@bedevere-app bedevere-app Bot removed the awaiting review label Dec 8, 2025
@maurycy

maurycy commented Dec 19, 2025

Copy link
Copy Markdown
Contributor Author

This is no longer needed, as per #142931
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@maurycy maurycy closed this Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 will be requested when the pull request is marked ready for review FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@maurycy @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.