GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142207: remove assertions incompatible under `profiling.sampling` by yihong0618 · Pull Request #142331 · python/cpython

Conversation

@yihong0618

@yihong0618 yihong0618 commented Dec 6, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

as diff

  • Issue: profiling.sampling may cause assert!(has_gil && gil_requested) to fail #142207

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@yihong0618
fix: close issue #142207 by drop the assert
ade0ef8 
Signed-off-by: yihong0618 <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label Dec 6, 2025
@yihong0618 yihong0618 changed the title fix: close issue #142207 by drop the assert gh-142207: close issue #142207 by drop the assert Dec 6, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 6, 2025
profiling.sampling may cause assert!(has_gil && gil_requested) to fail #142207
Closed
@yihong0618
fix: make news format right
82b16d8 
Signed-off-by: yihong0618 <[email protected]>
StanFromIreland
StanFromIreland reviewed Dec 6, 2025
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make the title more descriptive, it should give a rough idea of what the PR is about to someone that hasn't read the issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@yihong0618 yihong0618 changed the title gh-142207: close issue #142207 by drop the assert gh-142207: close issue #142207 by drop the assert that cause !(has_gil && gil_requested) when sampling Dec 6, 2025
@yihong0618

yihong0618 commented Dec 6, 2025

Copy link
Copy Markdown
Contributor Author

Can you please make the title more descriptive, it should give a rough idea of what the PR is about to someone that hasn't read the issue.

changed, sorry for that
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz changed the title gh-142207: close issue #142207 by drop the assert that cause !(has_gil && gil_requested) when sampling gh-142207: remove assertions incompatible under profiling.sampling Dec 6, 2025
pablogsal
pablogsal approved these changes Dec 8, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 8, 2025
@pablogsal

pablogsal commented Dec 8, 2025

Copy link
Copy Markdown
Member

Thanks for the fix!
yihong0618 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit 3db7bf2 into python:main Dec 8, 2025
50 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 8, 2025
@yihong0618
yihong0618 deleted the hy/close_issue_142207 branch December 8, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments
@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@yihong0618 @pablogsal @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.