GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142307: deprecate legacy support for altering ``IMAP4.file`` by picnixz · Pull Request #142335 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Dec 6, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The IMAP4.file attribute was never meant to be part of the public API. Previously, this attribute was created when opening a connection but subsequent changes may introduce a desynchronization with the underlying socket as the previous file is not closed.

  • Issue: imaplib 3.14 regression: IMAP4.file became read-only property, breaking subclass overrides (affects imapclient IMAP4_TLS) #142307

📚 Documentation preview 📚: https://cpython-previews--142335.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
pythongh-142307: restore legacy support for altering IMAP4.file
f28c0cc 
The ``IMAP4.file`` attribute was never meant to be part of
the public API. Previously, this attribute was created when
opening a connection but subsequent changes may introduce a
desynchronization with the underlying socket as the previous
file is not closed.
@picnixz
picnixz requested review from a team and AA-Turner as code owners December 6, 2025 12:24
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 6, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 6, 2025
imaplib 3.14 regression: IMAP4.file became read-only property, breaking subclass overrides (affects imapclient IMAP4_TLS) #142307
Closed
picnixz
picnixz commented Dec 6, 2025
View reviewed changes
Comment thread Lib/test/test_imaplib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
Update Lib/test/test_imaplib.py
f807145
@picnixz picnixz changed the title gh-142307: restore legacy support for altering IMAP4.file gh-142307: deprecate legacy support for altering IMAP4.file Dec 6, 2025
@picnixz
picnixz requested a review from serhiy-storchaka February 7, 2026 11:51
gpshead
gpshead approved these changes Feb 7, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 7, 2026
@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 3, 2026
@hugovk
Merge remote-tracking branch 'upstream/main' into fix/imaplib/propert…
8103087 
…y-142307
@hugovk

hugovk commented May 6, 2026

Copy link
Copy Markdown
Member

Hang on, will fix this conflict resolution.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
Fix merge conflict
b1a2060
hugovk
hugovk approved these changes May 6, 2026
View reviewed changes
@read-the-docs-community

read-the-docs-community Bot commented May 6, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32561723 | 📁 Comparing b1a2060 against main (70e365c)

  🔍 Preview build  

8 files changed · ± 8 modified

± Modified

  • deprecations/index.html
  • deprecations/pending-removal-in-3.19.html
  • library/imaplib.html
  • whatsnew/3.12.html
  • whatsnew/3.13.html
  • whatsnew/3.14.html
  • whatsnew/3.15.html
  • whatsnew/changelog.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk merged commit 7b6c248 into python:main May 6, 2026
52 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@hugovk hugovk hugovk approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@picnixz @hugovk @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.