GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142543: Mark tracer functions as Py_NO_INLINE by Fidget-Spinner · Pull Request #142846 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Dec 16, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #142543

I've verified on my system this fixes the crashes.

  • Issue: SIGSEGV in test_isinstance and test_json with --enable-experimental-jit=yes and --with-lto=full #142543

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fidget-Spinner
Mark tracer function as Py_NO_INLINE
7fced44
@Fidget-Spinner
Fidget-Spinner requested a review from markshannon as a code owner December 16, 2025 23:12
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 16, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 16, 2025
SIGSEGV in test_isinstance and test_json with --enable-experimental-jit=yes and --with-lto=full #142543
Closed
@Fidget-Spinner
mark more things as noinline
8f854b8
@Fidget-Spinner Fidget-Spinner changed the title gh-142543: Mark tracer function as Py_NO_INLINE gh-142543: Mark tracer functions as Py_NO_INLINE Dec 16, 2025
@Fidget-Spinner

Fidget-Spinner commented Dec 16, 2025

Copy link
Copy Markdown
Member Author

This is basically the same as #137731
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blurb-it
📜🤖 Added by blurb_it.
87ceff2
savannahostrowski
savannahostrowski approved these changes Dec 16, 2025
View reviewed changes

@savannahostrowski savannahostrowski left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 16, 2025
@Fidget-Spinner

Fidget-Spinner commented Dec 16, 2025

Copy link
Copy Markdown
Member Author

I'd like to get this in ASAP as this breaks JIT builds on all clang-based systems without tailcalling and with LTO on.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner added 2 commits December 16, 2025 23:37
@Fidget-Spinner
add comments
8ff4a63
@Fidget-Spinner
Merge branch 'no_inilne_tracer' of github.com:Fidget-Spinner/cpython …
04cf03a 
…into no_inilne_tracer
@Fidget-Spinner
Fidget-Spinner merged commit 89729f2 into python:main Dec 17, 2025
64 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 17, 2025
@Fidget-Spinner
Fidget-Spinner deleted the no_inilne_tracer branch December 17, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savannahostrowski savannahostrowski savannahostrowski approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SIGSEGV in test_isinstance and test_json with --enable-experimental-jit=yes and --with-lto=full

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Fidget-Spinner @savannahostrowski
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.