GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-129748: Remove TSan suppression for mi_block_set_nextx by colesbury · Pull Request #142887 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Dec 17, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The function was already changed to use a relaxed atomic store.

  • Issue: Data race on block->next in mi_block_set_nextx #129748

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-129748: Remove suppression for mi_block_set_nextx
d73d45b 
The function was already changed to use a relaxed atomic store.
@colesbury
colesbury requested a review from Yhg1s December 17, 2025 15:56
@colesbury colesbury added skip news topic-free-threading labels Dec 17, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 17, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 17, 2025
Data race on block->next in mi_block_set_nextx #129748
Closed
@colesbury colesbury changed the title gh-129748: Remove suppression for mi_block_set_nextx gh-129748: Remove TSan suppression for mi_block_set_nextx Dec 17, 2025
corona10
corona10 approved these changes Dec 17, 2025
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, not sure why I didn't remove this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 17, 2025
@colesbury
Merge branch 'main' into pythongh-129748-remove-suppression
0e17b38
@colesbury
colesbury merged commit 6e625f8 into python:main Dec 17, 2025
44 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
colesbury deleted the gh-129748-remove-suppression branch December 17, 2025 20:27
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@colesbury @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.