GeezerVison is showing github.com — bpo-37348: optimize decoding ASCII string by methane · Pull Request #14291 · python/cpython
Conversation
methane
commented
Jun 21, 2019
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
gcc and clang can not optimize this code well:
_PyUnicodeWriter_Init(&writer);
writer.min_length = size;
_PyUnicodeWriter_Prepare(&writer, size, maxchar);
Add _PyUnicodeWriter_InitPrepare() which does same thing, but
more compiler friendly.
https://bugs.python.org/issue37348
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
gcc and clang can not optimize this code well:
_PyUnicodeWriter_Init(&writer);
writer.min_length = size;
_PyUnicodeWriter_Prepare(&writer, size, maxchar);
Add _PyUnicodeWriter_InitPrepare() which does same thing, but
more compiler friendly.
|
#14283 is faster. _PyUnicode_Writer is a relatively large struct. Skip using it for a simple case is faster than initializing _PyUnicode_Writer.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.