GeezerVison is showing github.com — JIT: don't leak shim memory when shutting down the interpreter by diegorusso · Pull Request #142984 · python/cpython
Conversation
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already reviewed internally.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️
Hi! The buildbot s390x RHEL9 LTO + PGO 3.x (tier-3) has failed when building commit 450e836.
What do you need to do:
- Don't panic.
- Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
- Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1578/builds/3788) and take a look at the build logs.
- Check if the failure is related to this commit (450e836) or if it is a false positive.
- If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.
You can take a look at the buildbot page here:
https://buildbot.python.org/#/builders/1578/builds/3788
Summary of the results of the build (if available):
Click to see traceback logs
remote: Enumerating objects: 8, done.
remote: Counting objects: 16% (1/6)
remote: Counting objects: 33% (2/6)
remote: Counting objects: 50% (3/6)
remote: Counting objects: 66% (4/6)
remote: Counting objects: 83% (5/6)
remote: Counting objects: 100% (6/6)
remote: Counting objects: 100% (6/6), done.
remote: Compressing objects: 50% (1/2)
remote: Compressing objects: 100% (2/2)
remote: Compressing objects: 100% (2/2), done.
remote: Total 8 (delta 4), reused 4 (delta 4), pack-reused 2 (from 2)
From https://github.com/python/cpython
* branch main -> FETCH_HEAD
Note: switching to '450e836aefd5973fb1ecc130dafa9055d122838f'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at 450e836aefd JIT: don't leak shim memory when shutting down the interpreter (#142984)
Switched to and reset branch 'main'
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make[2]: [Makefile:3418: clean-retain-profile] Error 1 (ignored)
lto-wrapper: warning: using serial compilation of 4 LTRANS jobs
lto-wrapper: warning: using serial compilation of 4 LTRANS jobs
lto-wrapper: warning: using serial compilation of 6 LTRANS jobs
lto-wrapper: warning: using serial compilation of 2 LTRANS jobs
lto-wrapper: warning: using serial compilation of 4 LTRANS jobs
lto-wrapper: warning: using serial compilation of 3 LTRANS jobs
lto-wrapper: warning: using serial compilation of 3 LTRANS jobs
lto-wrapper: warning: using serial compilation of 3 LTRANS jobs
lto-wrapper: warning: using serial compilation of 2 LTRANS jobs
lto-wrapper: warning: using serial compilation of 2 LTRANS jobs
lto-wrapper: warning: using serial compilation of 7 LTRANS jobs
lto-wrapper: warning: using serial compilation of 4 LTRANS jobs
lto-wrapper: warning: using serial compilation of 3 LTRANS jobs
lto-wrapper: warning: using serial compilation of 2 LTRANS jobs
lto-wrapper: warning: using serial compilation of 3 LTRANS jobs
lto-wrapper: warning: using serial compilation of 128 LTRANS jobs
lto-wrapper: warning: using serial compilation of 6 LTRANS jobs
lto-wrapper: warning: using serial compilation of 2 LTRANS jobs
lto-wrapper: warning: using serial compilation of 128 LTRANS jobs
lto-wrapper: warning: using serial compilation of 128 LTRANS jobs
during IPA pass: profile
./Modules/posixmodule.c: In function ‘fill_time’:
./Modules/posixmodule.c:18824:1: internal compiler error: Segmentation fault
18824 | }
| ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://bugzilla.redhat.com/bugzilla> for instructions.
Preprocessed source stored into /tmp/cc97Xxs7.out file, please attach this to your bugreport.
make[1]: *** [Makefile:3863: Modules/posixmodule.o] Error 1
make[1]: *** Waiting for unfinished jobs....
Python/ceval.c: In function ‘_Py_BuildMap_StackRefSteal’:
Python/ceval.c:1327:11: warning: ‘args_o_temp’ may be used uninitialized [-Wmaybe-uninitialized]
1327 | res = _PyDict_FromItems(
| ^~~~~~~~~~~~~~~~~~
1328 | args_o, 2,
| ~~~~~~~~~~
1329 | args_o+1, 2,
| ~~~~~~~~~~~~
1330 | half_args
| ~~~~~~~~~
1331 | );
| ~
In file included from Python/ceval.c:13:
./Include/internal/pycore_dict.h:290:23: note: by argument 3 of type ‘struct PyObject * const *’ to ‘_PyDict_FromItems’ declared here
290 | PyAPI_FUNC(PyObject *)_PyDict_FromItems(
| ^~~~~~~~~~~~~~~~~
In file included from Python/ceval.c:1031:
Python/ceval.c:1322:52: note: ‘args_o_temp’ declared here
1322 | STACKREFS_TO_PYOBJECTS(arguments, half_args*2, args_o);
| ^~~~~~
Python/ceval.c: In function ‘_PyCallMethodDescriptorFast_StackRefSteal’:
Python/ceval.c:1214:11: warning: ‘args_o_temp’ may be used uninitialized [-Wmaybe-uninitialized]
1214 | res = cfunc(self, (args_o + 1), total_args - 1);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Python/ceval.c:1214:11: note: by argument 2 of type ‘struct PyObject * const *’ to ‘struct PyObject * <Td5d> (struct PyObject *, struct PyObject * const *, Py_ssize_t)’
In file included from Python/ceval.c:1031:
Python/ceval.c:1205:51: note: ‘args_o_temp’ declared here
1205 | STACKREFS_TO_PYOBJECTS(arguments, total_args, args_o);
| ^~~~~~
Python/ceval.c:1214:11: warning: ‘_232’ may be used uninitialized [-Wmaybe-uninitialized]
1214 | res = cfunc(self, (args_o + 1), total_args - 1);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Python/ceval.c:1214:11: note: by argument 2 of type ‘struct PyObject * const *’ to ‘struct PyObject * <Td5d> (struct PyObject *, struct PyObject * const *, Py_ssize_t)’
In file included from Python/ceval.c:1031:
Python/ceval.c:1205:51: note: ‘args_o_temp’ declared here
1205 | STACKREFS_TO_PYOBJECTS(arguments, total_args, args_o);
| ^~~~~~
Python/ceval.c: In function ‘_PyCallMethodDescriptorFastWithKeywords_StackRefSteal’:
Python/ceval.c:1248:11: warning: ‘args_o_temp’ may be used uninitialized [-Wmaybe-uninitialized]
1248 | res = cfunc(self, (args_o + 1), total_args-1, NULL);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Python/ceval.c:1248:11: note: by argument 2 of type ‘struct PyObject * const *’ to ‘struct PyObject * <Td63> (struct PyObject *, struct PyObject * const *, Py_ssize_t, struct PyObject *)’
In file included from Python/ceval.c:1031:
Python/ceval.c:1238:51: note: ‘args_o_temp’ declared here
1238 | STACKREFS_TO_PYOBJECTS(arguments, total_args, args_o);
| ^~~~~~
Python/ceval.c:1248:11: warning: ‘_232’ may be used uninitialized [-Wmaybe-uninitialized]
1248 | res = cfunc(self, (args_o + 1), total_args-1, NULL);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Python/ceval.c:1248:11: note: by argument 2 of type ‘struct PyObject * const *’ to ‘struct PyObject * <Td63> (struct PyObject *, struct PyObject * const *, Py_ssize_t, struct PyObject *)’
In file included from Python/ceval.c:1031:
Python/ceval.c:1238:51: note: ‘args_o_temp’ declared here
1238 | STACKREFS_TO_PYOBJECTS(arguments, total_args, args_o);
| ^~~~~~
make: *** [Makefile:1041: profile-opt] Error 2
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I had a look at the failure above and it seems not related to the change. Also subsequent builds succeeded on that worker.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
brandtbucher
Awaiting requested review from brandtbucher
brandtbucher is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|