GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142956: Add TOML 1.1.0 support by StanFromIreland · Pull Request #143028 · python/cpython

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Dec 20, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: TOML 1.1 #142956

📚 Documentation preview 📚: https://cpython-previews--143028.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
StanFromIreland added 3 commits December 20, 2025 20:07
@StanFromIreland
Updated to support TOML 1.1.0
8c15afd
@StanFromIreland
Improve test
8277daa
@StanFromIreland
!fixup Improve test
324dd67
@StanFromIreland
StanFromIreland requested review from AA-Turner, encukou and hauntsaninja as code owners December 20, 2025 20:14
@bedevere-app bedevere-app Bot mentioned this pull request Dec 20, 2025
TOML 1.1 #142956
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Dec 20, 2025
@AA-Turner

AA-Turner commented Dec 20, 2025

Copy link
Copy Markdown
Member

Should we wait for support in tomli? Currently the packages are kept broadly in sync.

hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead
gpshead approved these changes Dec 22, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 22, 2025
@gpshead

gpshead commented Dec 22, 2025

Copy link
Copy Markdown
Member

We should make sure PyPI's tomli is also updated. granted I assume it will be long before 3.15 is released.

One question for both libraries: now that there are syntax versions... when do we need to keep track of which version the parsed input conformed to? that probably matters more for tomli which presumably needs to be able to be told what version of toml to emit when writing, as things need to emit something compatible with the oldest reader.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou

encukou commented Dec 22, 2025

Copy link
Copy Markdown
Member

Should we wait for support in tomli? Currently the packages are kept broadly in sync.

Yes. I know it's against PEP 360, but, tomllib is effectively developed as tomli. That way it gets more extensive testing, and a backport.

This is tracked over at hukkin/tomli#273. If you have the time, could you help out there?

(I won't be able to look at this until January.)


when do we need to keep track of which version the parsed input conformed to?

AFAIK that would be mainly for ensuring that a given TOML file can be parsed by pre-3.15 versions of CPython.

tomllib was added for bootstrapping packaging tools. The fact that it does strict validation is a bonus, but not really needed. So, if TOML 1.1 is strictly backwards-compatible for valid inputs, we can just update.

However, if tomli adds a well-tested version knob, I think we should include it in tomllib as well.

[TOML versioning] probably matters more for tomli which presumably needs to be able to be told what version of toml to emit when writing

That's tomli-w; tomli is only for reading. (And given that tomli-w's output is not configurable, AFAIK it can ignore relaxed syntax.)

AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner AA-Turner closed this Dec 22, 2025
@AA-Turner

AA-Turner commented Dec 22, 2025

Copy link
Copy Markdown
Member

Closing for now, let's get support in tomli first.

A

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@StanFromIreland

StanFromIreland commented Dec 22, 2025

Copy link
Copy Markdown
Member Author

Why not just mark it as a draft?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@encukou encukou Awaiting requested review from encukou encukou is a code owner
@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja hauntsaninja is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@StanFromIreland @AA-Turner @gpshead @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.