GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-143026: Fix assertion error in executor management. by markshannon · Pull Request #143104 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Dec 23, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Also remove used _Py_DECREF_NO_DEALLOC function as it is no longer used.

  • Issue: JIT: assertion failure in _Py_DECREF_NO_DEALLOC #143026

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Fix assertion error in executor management.
3a90988 
Also remove used _Py_DECREF_NO_DEALLOC function as it is no longer used.
@markshannon
markshannon requested a review from Fidget-Spinner as a code owner December 23, 2025 16:19
@bedevere-app bedevere-app Bot mentioned this pull request Dec 23, 2025
JIT: assertion failure in _Py_DECREF_NO_DEALLOC #143026
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 23, 2025
@markshannon markshannon added the skip news label Dec 23, 2025
@markshannon

markshannon commented Dec 23, 2025

Copy link
Copy Markdown
Member Author

Skipping news as the bug never made it to a release
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner
Fidget-Spinner approved these changes Dec 23, 2025
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so my understanding is a pending deletion executor doesn't get re-added twice. Nice.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 23, 2025
Fidget-Spinner
Fidget-Spinner reviewed Dec 23, 2025
View reviewed changes
Comment thread Lib/test/test_capi/test_opt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
Run test out of process
81b53bd
Fidget-Spinner
Fidget-Spinner approved these changes Dec 23, 2025
View reviewed changes
@Fidget-Spinner

Fidget-Spinner commented Dec 23, 2025

Copy link
Copy Markdown
Member

Nice! The JIT tests are no longer failing. Merging.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Fidget-Spinner merged commit 20aeb3a into python:main Dec 23, 2025
71 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@markshannon @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.