GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116738: Add free-threading tests for binascii by raven-dev-ops · Pull Request #143234 · python/cpython

Conversation

@raven-dev-ops

@raven-dev-ops raven-dev-ops commented Dec 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Summary

  • Add free-threading regression coverage for binascii (Audit all built-in modules for thread safety #116738).
  • Assert that importing binascii does not enable the GIL when running with -X gil=0.
  • Add a multi-thread stress test for common binascii operations under -X gil=0.

Motivation

  • Built-in extension modules should be thread-safe in free-threaded builds and correctly declare their GIL usage.

Testing

  • Default build: ./python -m test -j0 test_binascii
  • Free-threaded build: ./python -X gil=0 -m test -j0 test_binascii

Issue

  • Audit all built-in modules for thread safety #116738

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@python-cla-bot

python-cla-bot Bot commented Dec 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Dec 28, 2025
@bedevere-app

bedevere-app Bot commented Dec 28, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Dec 28, 2025
Audit all built-in modules for thread safety #116738
Open
@bedevere-app bedevere-app Bot added the awaiting review label Dec 28, 2025
@bedevere-app

bedevere-app Bot commented Dec 28, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@raven-dev-ops raven-dev-ops changed the title gh-116738: add free-threading tests for binascii gh-116738: Add free-threading tests for binascii Dec 28, 2025
@raven-dev-ops raven-dev-ops closed this Dec 28, 2025
@raven-dev-ops
raven-dev-ops deleted the gh-116738-binascii-audit branch December 28, 2025 00:37
@raven-dev-ops
raven-dev-ops restored the gh-116738-binascii-audit branch December 28, 2025 01:02
@raven-dev-ops raven-dev-ops reopened this Dec 28, 2025
@bedevere-app

bedevere-app Bot commented Dec 28, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@raven-dev-ops
raven-dev-ops marked this pull request as draft December 28, 2025 02:10
@bedevere-app bedevere-app Bot removed the awaiting review label Dec 28, 2025
@raven-dev-ops

raven-dev-ops commented Dec 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

This is the first time I have tried to contribute to an open-source project, just let me know what I am doing wrong, I am thankful for your time.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@raven-dev-ops
raven-dev-ops marked this pull request as ready for review December 28, 2025 02:23
@bedevere-app bedevere-app Bot added the awaiting review label Dec 28, 2025
ZeroIntensity
ZeroIntensity reviewed Dec 29, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Tests/2025-12-27-20-13-12.gh-issue-116738.efglNB.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_binascii.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_binascii.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_binascii.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity ZeroIntensity added skip news topic-free-threading labels Dec 29, 2025
Damon A. Heath added 3 commits January 5, 2026 15:31
Damon A. Heath
gh-116738: Add free-threading tests for binascii
626a065
Damon A. Heath
gh-116738: Add NEWS entry
2ead2e3
Damon A. Heath
Adjust binascii free-threading tests
2f08189
raven-dev-ops
raven-dev-ops commented Jan 5, 2026
View reviewed changes

@raven-dev-ops raven-dev-ops left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added NEWS.d to pass the bot test, I saw the (skip-label), does mean I would have auto-passed without updating NEWS.d from the "bedevere-app"?

Edit: bedevere/news
bedevere/news — "skip news" label found (I will remove the NEWS since it did skip.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@raven-dev-ops raven-dev-ops closed this by deleting the head repository Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news tests Tests in the Lib/test dir topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@raven-dev-ops @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.