GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-20177: use builtin_dir to test METH_VARARGS by jdemeyer · Pull Request #14330 · python/cpython

Conversation

@jdemeyer

@jdemeyer jdemeyer commented Jun 24, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

CC @ZackerySpytz

https://bugs.python.org/issue20177

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pganssle reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@jdemeyer
bpo-20177: use builtin_dir to test METH_VARARGS
7c2b774
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 24, 2019
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jun 24, 2019
@jdemeyer jdemeyer mentioned this pull request Jun 24, 2019
gh-64376: Convert the time module to the Argument Clinic #14311
Closed
@vstinner

vstinner commented Jun 26, 2019

Copy link
Copy Markdown
Member

Maybe add a function to testcapi to not have to update tests each time the tested function uses a different calling convention.
pganssle reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pganssle
pganssle requested changes Jul 4, 2019
View reviewed changes

@pganssle pganssle left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @vstinner, these tests are fragile because it seems they're testing incidental implementation details of these builtins that are not guaranteed.

Unless these properties are guaranteed for backwards-compatibility, I think replacing these with dedicated test functions with a guaranteed calling method is the right way to test it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot

bedevere-bot commented Jul 4, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Jul 4, 2019
@jdemeyer jdemeyer closed this Jul 4, 2019
@larryhastings larryhastings mentioned this pull request Apr 10, 2022
Derby #8: Convert 28 sites to Argument Clinic across 2 files #64376
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle pganssle requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jdemeyer @vstinner @bedevere-bot @pganssle @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.