GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-127750: Fix annotations in singledispatchmethod signature tests (GH-143571) by miss-islington · Pull Request #143707 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 11, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

These tests relied on a bug -- gh-84644, which is that singledispatch
doesn't verify the annotation is on the "first" parameter.
(cherry picked from commit 620a5b9)

Co-authored-by: Bartosz Sławecki [email protected]

  • Issue: Regression in Django with singledispatchmethod on models #127750

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@johnslavik @miss-islington
pythongh-127750: Fix annotations in singledispatchmethod signature te…
9c7f1fc 
…sts (pythonGH-143571)

These tests relied on a bug -- pythongh-84644, which is that singledispatch
doesn't verify the annotation is on the "first" parameter.
(cherry picked from commit 620a5b9)

Co-authored-by: Bartosz Sławecki <[email protected]>
@miss-islington
miss-islington requested a review from rhettinger as a code owner January 11, 2026 19:24
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jan 11, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 11, 2026
Regression in Django with singledispatchmethod on models #127750
Closed
@bedevere-app bedevere-app Bot added awaiting review skip news labels Jan 11, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 11, 2026
gh-127750: Fix annotations in singledispatchmethod signature tests #143571
Merged
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) January 11, 2026 19:25
@serhiy-storchaka
serhiy-storchaka merged commit ea26c88 into python:3.14 Jan 11, 2026
51 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Jan 11, 2026
@miss-islington
miss-islington deleted the backport-620a5b9-3.14 branch January 11, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @serhiy-storchaka @johnslavik
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.