GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-143754: Use neutral terminology in tkinter documentation by VanshAgarwal24036 · Pull Request #143779 · python/cpython

Conversation

@VanshAgarwal24036

@VanshAgarwal24036 VanshAgarwal24036 commented Jan 13, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR updates the tkinter documentation to replace the term “slave” with
neutral alternatives such as “child widget”.

The changes are limited to documentation wording only and do not affect
APIs or behavior.

Fixes #143754.


📚 Documentation preview 📚: https://cpython-previews--143779.org.readthedocs.build/

  • Issue: tkinter source and docs use the word 'slave' #143754

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@VanshAgarwal24036
VanshAgarwal24036 requested a review from rhettinger as a code owner January 13, 2026 09:24
@bedevere-app bedevere-app Bot added the awaiting review label Jan 13, 2026
@VanshAgarwal24036 VanshAgarwal24036 changed the title Gh 143754 tkinter neutral terms gh-143754: Use neutral terminology in tkinter documentation Jan 13, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 13, 2026
tkinter source and docs use the word 'slave' #143754
Closed
@VanshAgarwal24036
Use neutral parent/child terminology in tkinter documentation
f50a321
@VanshAgarwal24036
VanshAgarwal24036 force-pushed the gh-143754-tkinter-neutral-terms branch from 102c344 to f50a321 Compare January 13, 2026 09:30
@VanshAgarwal24036

VanshAgarwal24036 commented Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

This PR is documentation-only, so it does not require a NEWS entry.
Could a maintainer please add the skip news label?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aisk aisk added the skip news label Jan 13, 2026
terryjreedy
terryjreedy requested changes Jan 14, 2026
View reviewed changes
Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/tkinter.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting review labels Jan 14, 2026
@bedevere-app

bedevere-app Bot commented Jan 14, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@VanshAgarwal24036
Refine tkinter terminology per review feedback
b630d3f
@VanshAgarwal24036

VanshAgarwal24036 commented Jan 14, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the clarification.

I’ve updated the paragraph to keep master for the container relationship
while removing slave, and adjusted the wording to stay within the scope
of this PR. I also fixed the winfo_parent markup warning.

Please let me know if this looks good now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@VanshAgarwal24036
VanshAgarwal24036 requested a review from terryjreedy January 14, 2026 03:24
@VanshAgarwal24036

VanshAgarwal24036 commented Jan 14, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@terryjreedy I have commited the suggested changes Please review and suggest if any change required

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@picnixz

picnixz commented Jan 18, 2026

Copy link
Copy Markdown
Member

I think Serhiy's PR addresses this already and in a better way. What has changed between these two PRs? I would also prefer Serhiy's PR as he has deep tkinter knowledge.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@VanshAgarwal24036

VanshAgarwal24036 commented Jan 19, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the clarification. Since Serhiy’s PR already covers this,
I’m happy to defer. Let me know if you’d like me to close this PR or
if you prefer to handle it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@terryjreedy

terryjreedy commented Jan 19, 2026

Copy link
Copy Markdown
Member

Thank you for starting this. Serhiy went back to the current tk docs for both docstrings and tkinter.rst.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@terryjreedy terryjreedy closed this Jan 19, 2026
@VanshAgarwal24036
VanshAgarwal24036 deleted the gh-143754-tkinter-neutral-terms branch January 19, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger
@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tkinter source and docs use the word 'slave'

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@VanshAgarwal24036 @picnixz @terryjreedy @aisk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.