GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — gh-143754: Use neutral terminology in tkinter documentation by VanshAgarwal24036 · Pull Request #143779 · python/cpython Conversation
|
|
This PR is documentation-only, so it does not require a NEWS entry. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for the clarification. I’ve updated the paragraph to keep Please let me know if this looks good now. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@terryjreedy I have commited the suggested changes Please review and suggest if any change required |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I think Serhiy's PR addresses this already and in a better way. What has changed between these two PRs? I would also prefer Serhiy's PR as he has deep tkinter knowledge. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for the clarification. Since Serhiy’s PR already covers this, |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thank you for starting this. Serhiy went back to the current tk docs for both docstrings and tkinter.rst. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
tkinter source and docs use the word 'slave'
There was an error while loading. Please reload this page.