GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-144132: Implement Suffix Automaton for difflib's Longest Common Substring by dg-pb · Pull Request #144164 · python/cpython

Conversation

@dg-pb

@dg-pb dg-pb commented Jan 22, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: difflib.GestaltSequenceMatcher implementation #144132

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dg-pb
dg-pb marked this pull request as draft January 22, 2026 19:48
@bedevere-app bedevere-app Bot mentioned this pull request Jan 22, 2026
difflib.GestaltSequenceMatcher implementation #144132
Closed
@bedevere-app bedevere-app Bot added awaiting review and removed awaiting review labels Jan 22, 2026
@dg-pb
take 2. round 1.
494c815
@dg-pb
dg-pb force-pushed the lcsub_automaton branch from e5a5124 to 494c815 Compare February 7, 2026 14:18
dg-pb added 11 commits February 7, 2026 16:37
@dg-pb
minor change
0a78769
@dg-pb
relax matcher argument type to callable
f650143
@dg-pb
comments, minor edits
70d501a
@dg-pb
documentation and tests
568b0ef
@dg-pb
visual example of skew in docstring
57548c8
@dg-pb
docstring worked example of balancing
5b0bbbf
@dg-pb
balancing score work
20730d6
@dg-pb
maximal bug fix
95734e8
@dg-pb
remove unused findall method
4a8289d
@dg-pb
score edits
2632c42
@dg-pb
minor edit
081e18e
@dg-pb
dg-pb marked this pull request as ready for review February 8, 2026 20:44
@bedevere-app bedevere-app Bot added the awaiting review label Feb 8, 2026
@dg-pb

dg-pb commented Feb 8, 2026

Copy link
Copy Markdown
Contributor Author

Code itself is ready for initial review.
Holding out on docs until definite consensus.

See issue for benchmarks and comparisons.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dg-pb added 2 commits February 9, 2026 14:08
@dg-pb
docstrings and variable names
3b2d26b
@dg-pb
differ argument instead of 2 matchers where appropriate + differ tests
24b183b
@dg-pb
dg-pb marked this pull request as draft February 10, 2026 16:37
@bedevere-app bedevere-app Bot removed the awaiting review label Feb 10, 2026
@dg-pb

dg-pb commented Feb 10, 2026

Copy link
Copy Markdown
Contributor Author

back to draft. went through related issues and got some new ideas to try.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dg-pb added 4 commits February 11, 2026 06:22
@dg-pb
ruff..
a33e873
@dg-pb
quadratic case handling
29007aa
@dg-pb
worst case complexity tests
0b3d72e
@dg-pb
cleanup
5900c9d
@dg-pb

dg-pb commented Feb 21, 2026

Copy link
Copy Markdown
Contributor Author

closing this for now, too much in 1 go.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dg-pb dg-pb closed this Feb 21, 2026
@dg-pb
dg-pb deleted the lcsub_automaton branch February 21, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@dg-pb
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.