GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-144125: email: verify headers are sound in BytesGenerator by miss-islington · Pull Request #144188 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 23, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 052e55e)

Co-authored-by: Seth Michael Larson [email protected]
Co-authored-by: Denis Ledoux [email protected]
Co-authored-by: Denis Ledoux [email protected]
Co-authored-by: Petr Viktorin [email protected]
Co-authored-by: Bas Bloemsaat [email protected]

  • Issue: Encode newlines in headers when using ByteGenerator #144125

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sethmlarson @beledouxdenis
@encukou @basbloemsaat @miss-islington
pythongh-144125: email: verify headers are sound in BytesGenerator
8df6632
(cherry picked from commit 052e55e)

Co-authored-by: Seth Michael Larson <[email protected]>
Co-authored-by: Denis Ledoux <[email protected]>
Co-authored-by: Denis Ledoux <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Bas Bloemsaat <[email protected]>
@miss-islington
miss-islington requested a review from a team as a code owner January 23, 2026 17:08
@bedevere-app bedevere-app Bot mentioned this pull request Jan 23, 2026
Encode newlines in headers when using ByteGenerator #144125
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Jan 23, 2026
@sethmlarson
sethmlarson requested a review from Yhg1s January 23, 2026 17:09
@sethmlarson sethmlarson added type-security A security issue release-blocker labels Jan 23, 2026
@github-project-automation github-project-automation Bot added this to Release and Deferred blockers 🚫 Jan 23, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Release and Deferred blockers 🚫 Jan 23, 2026
pablogsal
pablogsal reviewed Jan 25, 2026
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@encukou
Merge branch '3.12' into backport-052e55e-3.12
3dfb616
@encukou

encukou commented Jan 26, 2026

Copy link
Copy Markdown
Member

@webknjaz Hmm. Is this failure familiar?
The UI doesn't show any info:

image

But the downloadable logs contain:

Job is waiting for a hosted runner to come online.
2026-01-26T17:03:37.2490000Z Evaluating build-windows.if
2026-01-26T17:03:37.2490000Z Evaluating: (success() && (fromJSON(needs.build-context.outputs.run-windows-tests)))
2026-01-26T17:03:37.2490000Z Expanded: (true && true)
2026-01-26T17:03:37.2490000Z Result: true
2026-01-26T17:03:37.2490000Z Evaluating build-windows.arm64_false.build.if
2026-01-26T17:03:37.2490000Z Evaluating: success()
2026-01-26T17:03:37.2490000Z Result: true
2026-01-26T17:03:38.9380000Z Requested labels: windows-2022
2026-01-26T17:03:38.9380000Z Job defined at: python/cpython/.github/workflows/reusable-windows.yml@refs/pull/144188/merge
2026-01-26T17:03:38.9380000Z Reusable workflow chain:
2026-01-26T17:03:38.9380000Z python/cpython/.github/workflows/build.yml@refs/pull/144188/merge (615364956b0ea0a8353c2c5623362d88b20b1f48)
2026-01-26T17:03:38.9380000Z -> python/cpython/.github/workflows/reusable-windows.yml@refs/pull/144188/merge (615364956b0ea0a8353c2c5623362d88b20b1f48)
2026-01-26T17:03:38.9380000Z Waiting for a runner to pick up this job...
2026-01-26T17:03:39.8610000Z Job is about to start running on the hosted runner: GitHub Actions 1000510261
2026-01-26T17:03:39.8610000Z Job is waiting for a hosted runner to come online.
2026-01-26T17:03:43.2883707Z ##[error]Could not find a part of the path 'D:\a'.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

@encukou not sure but sound like a problem with their runners. I've restarted them in debug mode to see if that exposes anything else.

The cancellation behavior is rather weird — sounds like something in the jobs failed, then GHA went ahead to cancel them citing those same jobs as the reason for cancellation. Usually, jobs in matrices are marked as failed when they fail and if there's fail-fast, other jobs are marked as cancelled. Maybe, normal failed state cleanup timed out and GHA was cancelling those as well. But this is just a speculation..

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

Oh.. I didn't notice this is an old branch. It's probably a good idea to diff the CI infra with main. This is one of the reasons I insist on backporting all the CI changes into all the branches.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

So merging #144036 30 minutes ago failed. It's the last commit on the branch. Yesterday, everything was fine, though (when Pablo merged the target branch into that PR). So this is new.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

Looking at https://github.com/actions/runner-images?tab=readme-ov-file#available-images, the last windows-2022 runner rebuild was on Jan 19, it seems.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

Trying to restart jobs one at a time with debugging on.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz webknjaz moved this to 🚧 In progress 🚧 in 📅 Procrastinating in public 😵‍💫 Jan 26, 2026
@webknjaz webknjaz added this to 📅 Procrastinating in public 😵‍💫 Jan 26, 2026
@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

Looks like Win32 is the problem.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

Weird.. I've seen each of those jobs crashing flakily. But mostly when they ran in parallel. Now that I've restarted each individually, they seem to be running fine. Definitely a platform problem...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz

webknjaz commented Jan 26, 2026

Copy link
Copy Markdown
Member

@encukou it's probably a good idea to complain to GH support unless it self-heals.


I've downloaded the logs from https://github.com/python/cpython/actions/runs/21365488062/job/61510137519 (DEBUG RUN!)

And they've got something similar:

$ cat 1_Windows\ _\ build\ and\ test\ \(Win32\).txt
2026-01-26T18:39:28.6558234Z ##[debug]Starting: Windows / build and test (Win32)
2026-01-26T18:39:28.6630888Z ##[error]Could not find a part of the path 'D:\a'.
2026-01-26T18:39:28.6637136Z ##[debug]System.IO.DirectoryNotFoundException: Could not find a part of the path 'D:\a'.
2026-01-26T18:39:28.6638073Z ##[debug]   at System.IO.FileSystem.CreateDirectory(String fullPath, Byte[] securityDescriptor)
2026-01-26T18:39:28.6638844Z ##[debug]   at System.IO.Directory.CreateDirectory(String path)
2026-01-26T18:39:28.6639798Z ##[debug]   at GitHub.Runner.Worker.JobRunner.RunAsync(AgentJobRequestMessage message, CancellationToken jobRequestCancellationToken)
2026-01-26T18:39:28.6655833Z ##[debug]Finishing: Windows / build and test (Win32)

$ cat Windows\ _\ build\ and\ test\ \(Win32\)/system.txt
2026-01-26T18:39:25.2470000Z Requested labels: windows-2022
2026-01-26T18:39:25.2470000Z Job defined at: python/cpython/.github/workflows/reusable-windows.yml@refs/pull/144188/merge
2026-01-26T18:39:25.2470000Z Reusable workflow chain:
2026-01-26T18:39:25.2470000Z python/cpython/.github/workflows/build.yml@refs/pull/144188/merge (615364956b0ea0a8353c2c5623362d88b20b1f48)
2026-01-26T18:39:25.2470000Z -> python/cpython/.github/workflows/reusable-windows.yml@refs/pull/144188/merge (615364956b0ea0a8353c2c5623362d88b20b1f48)
2026-01-26T18:39:25.2470000Z Waiting for a runner to pick up this job...
2026-01-26T18:39:25.2450000Z Evaluating build-windows.if
2026-01-26T18:39:25.2450000Z Evaluating: (success() && (fromJSON(needs.build-context.outputs.run-windows-tests)))
2026-01-26T18:39:25.2450000Z Expanded: (true && true)
2026-01-26T18:39:25.2450000Z Result: true
2026-01-26T18:39:25.2450000Z Evaluating build-windows.Win32_false.build.if
2026-01-26T18:39:25.2450000Z Evaluating: success()
2026-01-26T18:39:25.2450000Z Result: true
2026-01-26T18:39:25.7450000Z Job is waiting for a hosted runner to come online.
2026-01-26T18:39:25.7450000Z Job is about to start running on the hosted runner: GitHub Actions 1000510807

This one has a trace in debug ^

The runner diagnostic logs don't have anything interesting and also seem to only have the alls-green job details with Ubuntu paths inside and nothing about Windows.

Attaching the logs for history: logs_55453059899.zip.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou

encukou commented Jan 27, 2026

Copy link
Copy Markdown
Member

Thanks for the investigation!

it's probably a good idea to complain to GH support unless it self-heals.

I'll keep an eye out for this happening again.

webknjaz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz

webknjaz commented Jan 27, 2026

Copy link
Copy Markdown
Member

So merging #144036 30 minutes ago failed. It's the last commit on the branch. Yesterday, everything was fine, though (when Pablo merged the target branch into that PR). So this is new.

I've just restarted the failing jobs on that commit and it they didn't crash immediately: https://github.com/python/cpython/actions/runs/21366922074. So I think it's safe to say the flaky behavior is gone for now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz webknjaz moved this from 🚧 In progress 🚧 to 🌈 Done 🦄 in 📅 Procrastinating in public 😵‍💫 Jan 27, 2026
@kbrezina

kbrezina commented Feb 9, 2026

Copy link
Copy Markdown

Hey guys,
I wonder whether I can expect 3.12.13 anytime soon? I suppose these changes are required for it.
Thanks for info.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sethmlarson

sethmlarson commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Going to merge this one since @pablogsal left a LGTM above. Thanks everyone for the investigation.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sethmlarson
sethmlarson merged commit e417f05 into python:3.12 Feb 13, 2026
186 of 217 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@github-project-automation github-project-automation Bot moved this from Todo to Done in Release and Deferred blockers 🚫 Feb 13, 2026
@bedevere-app bedevere-app Bot removed the awaiting review label Feb 13, 2026
@miss-islington
miss-islington deleted the backport-052e55e-3.12 branch February 13, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal left review comments
@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

release-blocker type-security A security issue

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@miss-islington @encukou @webknjaz @kbrezina @sethmlarson @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.