GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-140824: remove math.integer submodule name for sys.stdlib_module_names by skirpichev · Pull Request #144294 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented Jan 28, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Make the math module an extension package #140824

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skirpichev
pythongh-140824: workaround math.integer module name for sys.stdlib_m…
adc2bd0 
…odule_names
@skirpichev skirpichev added the skip news label Jan 28, 2026
@skirpichev
skirpichev requested a review from ericsnowcurrently as a code owner January 28, 2026 02:59
@bedevere-app bedevere-app Bot mentioned this pull request Jan 28, 2026
Make the math module an extension package #140824
Open
@bedevere-app bedevere-app Bot added the awaiting review label Jan 28, 2026
@skirpichev

skirpichev commented Jan 28, 2026

Copy link
Copy Markdown
Member Author

CC @vstinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland

StanFromIreland commented Jan 28, 2026

Copy link
Copy Markdown
Member

This is inconsistent, and is against the docs:

sub-packages and sub-modules are not listed.

I agree that in some cases this is a quite serious limitation, e.g. in the case of compression.zstd, but I think this should be fixed properly and not confused with exceptions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev
remove _math_integer from sys.stdlib_module_names
12850fd
@skirpichev skirpichev changed the title gh-140824: workaround math.integer module name for sys.stdlib_module_names gh-140824: remove math.integer submodule name for sys.stdlib_module_names Jan 28, 2026
@skirpichev

skirpichev commented Jan 28, 2026

Copy link
Copy Markdown
Member Author

Does make sense, updated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jan 28, 2026

Copy link
Copy Markdown
Member

Why do you want to hide the fact that _math_integer is part of the stdlib?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev

skirpichev commented Jan 28, 2026

Copy link
Copy Markdown
Member Author

As Stan pointed out above, the docs says that the set shouldn't include submodules:

For packages, only the main package is listed: sub-packages and sub-modules are not listed. For example, the email package is listed, but the email.mime sub-package and the email.message sub-module are not listed.

So, I think that removing is an option, not renaming.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jan 28, 2026

Copy link
Copy Markdown
Member

But technically, _math_integer contains no dot, it's not a submodule :-( I would suggest to leave it in stdlib_module_names.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev

skirpichev commented Jan 28, 2026

Copy link
Copy Markdown
Member Author

Ok, lets then leave it as is. But I suspect it will disappear with solving #140824.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev skirpichev closed this Jan 28, 2026
@skirpichev
skirpichev deleted the stdlib_module_names/140824 branch January 28, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@skirpichev @StanFromIreland @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.