GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-144270: Fix xml.etree.ElementTree.SubElement signature inconsistency by priyanshu2282-cyber · Pull Request #144313 · python/cpython

Conversation

@priyanshu2282-cyber

@priyanshu2282-cyber priyanshu2282-cyber commented Jan 28, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The Python and C implementations of xml.etree.ElementTree.SubElement exposed different call signatures the Python version allowed parent as a keyword argument, while the C version did not. This change makes the Python signature consistent with the C implementation. Passing parent as a keyword argument now raises TypeError. A regression test is added.

  • Issue: xml.etree.ElementTree.SubElement definition is incorrect / inconsistent with C #144270

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@priyanshu2282-cyber
Fix SubElement to make parent positional-only
349e029
@bedevere-app bedevere-app Bot added the awaiting review label Jan 28, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 28, 2026
xml.etree.ElementTree.SubElement definition is incorrect / inconsistent with C #144270
Closed
@blurb-it
📜🤖 Added by blurb_it.
be6dd5b
picnixz
picnixz requested changes Jan 28, 2026
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong way to fix it. We should fix the Python signature, not the C one. And if the C signature needs to be fixed, you must update Parse() call not do it manually.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting review labels Jan 28, 2026
@picnixz picnixz closed this Jan 28, 2026
@bedevere-app

bedevere-app Bot commented Jan 28, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@picnixz

picnixz commented Jan 28, 2026

Copy link
Copy Markdown
Member

The issue clearly stated that the problem was not the C implementation but the Python one. If you are using AI to generate PRs, please don't, because I'm tired of seeing AI-generated PRs. These past months, there were many new contributors that simply used an LLM to generate their PRs, which usually get closed either because they are wrong or because users don't address our comments.

You are welcome to use an LLM if you need to understand the surrounding code, but you are not allowed to use one to write your PR. And unless you review the LLM-generated code and verify that the regression test catches the correct thing, don't open a PR.

hyongtao-code reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@priyanshu2282-cyber

priyanshu2282-cyber commented Jan 28, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback, I undertand that the PR took the wrong approach, I see now that the correct fix is to update Parse() call, I agree I did use LLM, to understand the surrounding code and API expectations, but the implementation and test were reviewed and written by me. I appreciate you taking the time to review and explain the issue. Sorry for the inconvenience, and thanks for taking the time to review.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@priyanshu2282-cyber @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.