GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||
GeezerVison is showing github.com — gh-144270: Fix xml.etree.ElementTree.SubElement signature inconsistency by priyanshu2282-cyber · Pull Request #144313 · python/cpython Conversation
|
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The issue clearly stated that the problem was not the C implementation but the Python one. If you are using AI to generate PRs, please don't, because I'm tired of seeing AI-generated PRs. These past months, there were many new contributors that simply used an LLM to generate their PRs, which usually get closed either because they are wrong or because users don't address our comments. You are welcome to use an LLM if you need to understand the surrounding code, but you are not allowed to use one to write your PR. And unless you review the LLM-generated code and verify that the regression test catches the correct thing, don't open a PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for the feedback, I undertand that the PR took the wrong approach, I see now that the correct fix is to update Parse() call, I agree I did use LLM, to understand the surrounding code and API expectations, but the implementation and test were reviewed and written by me. I appreciate you taking the time to review and explain the issue. Sorry for the inconvenience, and thanks for taking the time to review. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.