GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-132132: Upgrade to VS 2026 on Windows tailcall CI by Fidget-Spinner · Pull Request #144516 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Feb 5, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This save us a lot of CI resources as we don't need to choco install anything now.

  • Issue: Improve the tail calling CI #132132

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Fidget-Spinner
Fidget-Spinner requested review from AA-Turner, ezio-melotti, hugovk and webknjaz as code owners February 5, 2026 17:08
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 5, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Feb 5, 2026
Improve the tail calling CI #132132
Open
@Fidget-Spinner Fidget-Spinner added the skip news label Feb 5, 2026
hugovk
hugovk reviewed Feb 5, 2026
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference: https://github.blog/changelog/2026-02-05-github-actions-early-february-2026-updates/#windows-server-2025-with-visual-studio-2026-image-now-available-for-github-hosted-runners

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread .github/actionlint.yaml
Comment on lines 2 to 3
# Pending https://github.com/rhysd/actionlint/issues/533
# and https://github.com/rhysd/actionlint/issues/571

@hugovk hugovk Feb 5, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Pending https://github.com/rhysd/actionlint/issues/533
# and https://github.com/rhysd/actionlint/issues/571
# Pending https://github.com/rhysd/actionlint/pull/615

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread .github/actionlint.yaml Outdated
# Pending https://github.com/rhysd/actionlint/issues/533
# and https://github.com/rhysd/actionlint/issues/571
labels: ["windows-11-arm", "macos-15-intel"]
labels: ["windows-11-arm", "macos-15-intel", "windows-2025-vs2026"]

@hugovk hugovk Feb 5, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
labels: ["windows-11-arm", "macos-15-intel", "windows-2025-vs2026"]
labels: ["windows-2025-vs2026"]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hugovk

hugovk commented Feb 5, 2026

Copy link
Copy Markdown
Member

Hmm, the runner doesn't seem to be available:

x86_64-pc-windows-msvc/msvc
Started 1h 22m 49s ago

Requested labels: windows-2025-vs2026
Job defined at: python/cpython/.github/workflows/tail-call.yml@refs/pull/144516/merge
Waiting for a runner to pick up this job...
Evaluating tail-call.if
Evaluating: success()
Result: true

https://github.com/python/cpython/actions/runs/21721176273/job/62651063296?pr=144516

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk mentioned this pull request Feb 5, 2026
[windows] Add Windows Server 2025 with Visual Studio 2026 actions/runner-images#13635
Merged
1 of 4 tasks
@hugovk

hugovk commented Feb 5, 2026

Copy link
Copy Markdown
Member

Looks like they announced availability prematurely and they'll need to merge actions/runner-images#13635 first.

StanFromIreland reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented Feb 6, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It's running now and test_dtrace is failing, for example:

======================================================================
FAIL: test_verify_call_opcodes (test.test_dtrace.DTraceOptimizedTests.test_verify_call_opcodes)
Ensure our call stack test hits all function call opcodes
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 149, in test_verify_call_opcodes
    self.assertEqual(set(), opcodes)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
AssertionError: Items in the second set but not the first:
'CALL_FUNCTION'
'CALL_FUNCTION_KW'

And:

======================================================================
FAIL: test_gc (test.test_dtrace.DTraceNormalTests.test_gc)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 38, in normalize_trace_output
    result.sort(key=lambda row: int(row[0]))
    ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 38, in <lambda>
    result.sort(key=lambda row: int(row[0]))
                                ~~~^^^^^^^^
ValueError: invalid literal for int() with base 10: 'dtrace: failed to compile script D:\\a\\cpython\\cpython\\Lib\\test\\dtracedata\\gc.d: line 1: pid provider is not installed on this system'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 152, in test_gc
    self.run_case("gc")
    ~~~~~~~~~~~~~^^^^^^
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 119, in run_case
    actual_output, expected_output = self.backend.run_case(
                                     ~~~~~~~~~~~~~~~~~~~~~^
        name, optimize_python=self.optimize_python)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 53, in run_case
    actual_output = normalize_trace_output(self.trace_python(
        script_file=abspath(name + self.EXTENSION),
        python_file=abspath(name + ".py"),
        optimize_python=optimize_python))
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 42, in normalize_trace_output
    raise AssertionError(
        "tracer produced unparsable output:\n{}".format(output)
    )
AssertionError: tracer produced unparsable output:
dtrace: failed to compile script D:\a\cpython\cpython\Lib\test\dtracedata\gc.d: line 1: pid provider is not installed on this system

https://github.com/python/cpython/actions/runs/21721176273/job/62741886874?pr=144516

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Fidget-Spinner

Fidget-Spinner commented Feb 6, 2026

Copy link
Copy Markdown
Member Author

@hugovk apparently this is a prior known bug for this runner #138744

I suggest we just skip the test on Windows 11?

chris-eibl reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Feb 6, 2026

Copy link
Copy Markdown
Member

I suggest we just skip the test on Windows 11?

test_dtrace can be skipped on Windows, yes.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Fidget-Spinner

Fidget-Spinner commented Feb 6, 2026

Copy link
Copy Markdown
Member Author

Sorry I realised I opened the PR from the wrong branch. Let me close and re-open another PR

hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Fidget-Spinner Fidget-Spinner closed this Feb 6, 2026
@Fidget-Spinner
Fidget-Spinner force-pushed the main branch from ebd4280 to 7e777c5 Compare February 6, 2026 13:40
@Fidget-Spinner

Fidget-Spinner commented Feb 6, 2026

Copy link
Copy Markdown
Member Author

New PR open at #144544

hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz webknjaz moved this to 🌈 Done 🦄 in 📅 Procrastinating in public 😵‍💫 Feb 6, 2026
@webknjaz webknjaz added this to 📅 Procrastinating in public 😵‍💫 Feb 6, 2026
@chris-eibl chris-eibl mentioned this pull request Feb 6, 2026
gh-132132: Upgrade to VS 2026 on Windows tailcall CI #144544
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti
@AA-Turner AA-Turner Awaiting requested review from AA-Turner
@webknjaz webknjaz Awaiting requested review from webknjaz

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Fidget-Spinner @hugovk @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.