GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-144446: Fix some frame object thread-safety issues (gh-144479) by miss-islington · Pull Request #144546 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 6, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix thread-safety issues when accessing frame attributes while another
thread is executing the frame:

  • Add critical section to frame_repr() to prevent races when accessing
    the frame's code object and line number

  • Add _Py_NO_SANITIZE_THREAD to PyUnstable_InterpreterFrame_GetLasti()
    to allow intentional racy reads of instr_ptr.

  • Fix take_ownership() to not write to the original frame's f_executable
    (cherry picked from commit 5bb3bbb)

Co-authored-by: Sam Gross [email protected]

  • Issue: Data races with frame objects #144446

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@colesbury @miss-islington
pythongh-144446: Fix some frame object thread-safety issues (pythongh…
d92a7fb
…-144479)

Fix thread-safety issues when accessing frame attributes while another
thread is executing the frame:

- Add critical section to frame_repr() to prevent races when accessing
  the frame's code object and line number

- Add _Py_NO_SANITIZE_THREAD to PyUnstable_InterpreterFrame_GetLasti()
  to allow intentional racy reads of instr_ptr.

- Fix take_ownership() to not write to the original frame's f_executable
(cherry picked from commit 5bb3bbb)

Co-authored-by: Sam Gross <[email protected]>
@miss-islington
miss-islington requested a review from markshannon as a code owner February 6, 2026 14:43
@bedevere-app bedevere-app Bot added the awaiting review label Feb 6, 2026
This was referenced Feb 6, 2026
Data races with frame objects #144446
Open
gh-144446: Fix some frame object thread-safety issues #144479
Merged
@bedevere-app bedevere-app Bot added the topic-free-threading label Feb 6, 2026
@colesbury
colesbury enabled auto-merge (squash) February 6, 2026 14:52
@colesbury
colesbury disabled auto-merge February 6, 2026 14:57
@colesbury
Update run_concurrently from main branch
7e79bfb
@colesbury
colesbury enabled auto-merge (squash) February 6, 2026 15:14
@colesbury
colesbury merged commit 6006005 into python:3.14 Feb 6, 2026
47 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting review label Feb 6, 2026
@miss-islington
miss-islington deleted the backport-5bb3bbb-3.14 branch February 6, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.