GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||
GeezerVison is showing github.com — gh-106318: Improve str.lower() docs by adorilson · Pull Request #144848 · python/cpython Conversation
|
| character(s) is not "Lu" (Letter, uppercase), but e.g. "Lt" (Letter, | ||
| titlecase). | ||
|
|
||
| For example, see the word "Python" written in Punjabi, the most spoken |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I don’t think the fact is particularly interesting nor helpful, I think it just unnecessarily extends the section.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the whole adding or only the example?
The note paragraph was based on what already exists in the str.upper() docs. If this exists there, I think it makes sense exist here too.
The example I've suggested adds to str.upper() docs on #144638. I would prefer a more Occidental example, but I couldn't find one. I think examples are important.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I was referring to specifically the "most spoken language in..." fact.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I was referring to specifically the "most spoken language in..." fact.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Oh, nice. I've put it because if I see only "written in Punjabi", I would think "wtf is Punjabi?". Of course, I would search about that, but I thought it could be ended here.
That being said, we can:
What do you prefer?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer 3. It's clear that it's a language, and you can look it up in a dictionary to learn more.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Documentation build overview
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.