GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106318: Improve str.lower() docs by adorilson · Pull Request #144848 · python/cpython

Conversation

@adorilson

@adorilson adorilson commented Feb 15, 2026 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

WIP #106318

This PR adds some details to str.lower() to make it similar to str.upper() proposed by #144638.

  • Issue: Add examples to docs for str methods #106318

📚 Documentation preview 📚: https://cpython-previews--144848.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@adorilson
pythongh-106318: Improve str.lower() docs
5c7733a
@bedevere-app bedevere-app Bot mentioned this pull request Feb 15, 2026
Add examples to docs for str methods #106318
Open
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Feb 15, 2026
@github-project-automation github-project-automation Bot added this to Docs PRs Feb 15, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Feb 15, 2026
StanFromIreland
StanFromIreland reviewed Feb 15, 2026
View reviewed changes
Comment thread Doc/library/stdtypes.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/builtins/stdtypes.rst
character(s) is not "Lu" (Letter, uppercase), but e.g. "Lt" (Letter,
titlecase).

For example, see the word "Python" written in Punjabi, the most spoken

@StanFromIreland StanFromIreland Feb 15, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think the fact is particularly interesting nor helpful, I think it just unnecessarily extends the section.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@adorilson adorilson Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the whole adding or only the example?

The note paragraph was based on what already exists in the str.upper() docs. If this exists there, I think it makes sense exist here too.

The example I've suggested adds to str.upper() docs on #144638. I would prefer a more Occidental example, but I couldn't find one. I think examples are important.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@StanFromIreland StanFromIreland Feb 16, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to specifically the "most spoken language in..." fact.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@StanFromIreland StanFromIreland Feb 16, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to specifically the "most spoken language in..." fact.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@adorilson adorilson Feb 16, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice. I've put it because if I see only "written in Punjabi", I would think "wtf is Punjabi?". Of course, I would search about that, but I thought it could be ended here.

That being said, we can:

  1. Keep it (in case you change your mind)
  2. Reduce to "written in Punjabi, a language from Paskitan"
  3. Reduce more to "written in Punjabi"
  4. 3 + adding a link to the Punjabi Wikipedia entry.

What do you prefer?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@encukou encukou Nov 4, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer 3. It's clear that it's a language, and you can look it up in a dictionary to learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@adorilson
pythongh-106318: Replace latin abreviation on str.lower() docs
95297c0
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 6, 2026
@ambv ambv mentioned this pull request Oct 20, 2026
gh-106318: Add example for str.maketrans() #142822
Closed
@encukou
Merge in the main branch
1ed2258
@read-the-docs-community

read-the-docs-community Bot commented Nov 4, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35647203 | 📁 Comparing 1ed2258 against main (0d3ab6f)

  🔍 Preview build  

1 file changed
± builtins/stdtypes.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@StanFromIreland StanFromIreland StanFromIreland left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@adorilson @encukou @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.