GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — gh-144846: make Element tag positional-only by NekoAsakura · Pull Request #144876 · python/cpython Conversation
|
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@bkap123 cheers for the review. While I'm at it, do I need to make the same change over on #144845 (the SubElement one) as well, or is that alright as is? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This PR changes the behavior of the public APIs and may affect users' code, so a news entry is required. #144845 is the same. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
6f67486 to
aa2871b
Compare
|
Thanks for the reminder! I've added news entries to both PRs. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Left small suggestion |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| an optional dictionary, containing element attributes. *extra* contains | ||
| additional attributes, given as keyword arguments. | ||
|
|
||
| .. versionchanged:: 3.15 |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
| .. versionchanged:: 3.15 | |
| .. versionchanged:: next |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
|
||
| # 'attrib' can be passed as keyword | ||
| e = ET.Element('e', attrib={'key': 'value'}) | ||
| self.assertEqual(e.get('key'), 'value') |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Maybe test also the attribute name 'attrib'?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Closing in favour of #144845, which already includes this change. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.