GeezerVison

Would it be good if _GUARD_NOS_FROZEN_DICT was added to optimizer_bytecodes.c so that it could be removed by the optimizer if the type is known?

I think it's better to focus on getting the specializer correct in this PR for now. We can leave the JIT for another PR.

@Sacul0457 I think that we have to, I will update the PR or handle it at the seperate PR, but it needs feedback from JIT team first :)

This needs tests in test_opcache for the specialization success and failure case.

Once the PR is merged, I am also going to work on CONTAINS_OP_FROZENDICT too.

@Fidget-Spinner Now whole unit tests are passed.

Do you have any evidence that this will improve performance?

Opcodes are a limited resource, and since no one is using frozen dicts yet, this is just going to slow down the interpreter by adding bulk.

Relaxing the guard in BINARY_OP_SUBSCR_DICT to check for any dict, and removing the redundant check in PyDict_GetItemRef would achieve your goal without lots of extra code or any slow down.

Relaxing the guard in BINARY_OP_SUBSCR_DICT to check for any dict, and removing the redundant check in PyDict_GetItemRef would achieve your goal without lots of extra code or any slow down.

I like that option too.

@corona10 wrote #144949 to modify existing CONTAINS_OP_DICT and BINARY_OP_SUBSCR_DICT opcodes for frozendict. I close this PR.