GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145230: Update lockbench.py and benchmark_locks API by gourijain029-del · Pull Request #145271 · python/cpython

Conversation

@gourijain029-del

@gourijain029-del gourijain029-del commented Feb 26, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

PR Description
Updates

lockbench.py
and the internal

benchmark_locks
API to support more realistic PyMutex benchmarking.

Key Changes:

New Metrics: Added --work-outside, --num-locks, and --total-iters to simulate varying contention levels and measure fairness.
Redundancy: Removed PyThread_type_lock benchmarking as it now uses PyMutex.
CLI: Switched to argparse and made the number of threads configurable.
Efficiency: Added cache-line padding to mutex states in C to prevent false sharing during multi-lock tests.

  • Issue: Update lockbench.py #145230

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@gourijain029-del
pythongh-145230: Update lockbench.py and benchmark_locks API
aa29467
- Remove PyThread_type_lock benchmark as it now uses PyMutex.\n- Add --work-outside to adjust work outside critical sections.\n- Add --num-locks to support benchmarking multiple independent locks.\n- Make number of threads configurable.\n- Add --total-iters for fixed iteration benchmarks.
@bedevere-app bedevere-app Bot added the awaiting review label Feb 26, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Feb 26, 2026
Update lockbench.py #145230
Closed
@bedevere-app

bedevere-app Bot commented Feb 26, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@colesbury

colesbury commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Thank you, but I already have a PR that makes the changes I described.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@colesbury colesbury closed this Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gourijain029-del @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.