GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145524: Update comment for TypeVar S in typing.rst by hyperkai · Pull Request #145525 · python/cpython

Conversation

@hyperkai

@hyperkai hyperkai commented Mar 5, 2026 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix: #145524

  • Issue: What type bound parameter of typing.TypeVar accepts should be explained more clearly #145524

📚 Documentation preview 📚: https://cpython-previews--145525.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hyperkai
Update comment for TypeVar S in typing.rst
6a26b06 
Clarified the comment for type variable S to specify it can be str or any subtype of str.
@hyperkai
hyperkai requested review from AlexWaygood and JelleZijlstra as code owners March 5, 2026 04:44
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Mar 5, 2026
@github-project-automation github-project-automation Bot added this to Docs PRs Mar 5, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Mar 5, 2026
@bedevere-app bedevere-app Bot added the awaiting review label Mar 5, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 5, 2026
What type bound parameter of typing.TypeVar accepts should be explained more clearly #145524
Open
AlexWaygood
AlexWaygood approved these changes Mar 5, 2026
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing text is correct, since str is a subtype of str -- "any subtype of str" includes str itself. But I agree that not all users will necessarily be aware of that, so the edit does seem to make things clearer to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 5, 2026
@AlexWaygood AlexWaygood added awaiting review needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes and removed awaiting merge labels Mar 5, 2026
encukou
encukou reviewed Mar 10, 2026
View reviewed changes
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.15 bugs and security fixes label May 30, 2026
@JelleZijlstra
Update Doc/library/typing.rst
8ec6c94
@read-the-docs-community

read-the-docs-community Bot commented Jun 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32972593 | 📁 Comparing 1fdc331 against main (6453065)

  🔍 Preview build  

1 file changed
± library/typing.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
Merge branch 'main' into hyperkai-patch-2
1fdc331
JelleZijlstra
JelleZijlstra approved these changes Aug 29, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge docs Documentation in the Doc dir needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes skip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

What type bound parameter of typing.TypeVar accepts should be explained more clearly

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@hyperkai @encukou @JelleZijlstra @AlexWaygood @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.