GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-145376: Fix crashes in md5module.c (GH-145422) by eendebakpt · Pull Request #145611 · python/cpython

Conversation

@eendebakpt

@eendebakpt eendebakpt commented Mar 6, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix a possible NULL pointer dereference in md5module.c.
This can only occur in error paths taken when the interpreter fails to allocate memory.

(cherry-picked from c1d7768)

  • Issue: Various reference leaks in the core #145376

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eendebakpt
pythongh-145376: Fix crashes in md5module.c
3b1aa5f 
Fix a possible NULL pointer dereference in `md5module.c`.
This can only occur in error paths taken when the interpreter fails to allocate memory.

(cherry-picked from c1d7768)
@eendebakpt
eendebakpt requested review from gpshead and tiran as code owners March 6, 2026 20:14
@bedevere-app bedevere-app Bot mentioned this pull request Mar 6, 2026
Various reference leaks in the core #145376
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Mar 6, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 6, 2026
gh-145376: Fix null pointer deref in md5module.c #145422
Merged
@blurb-it
📜🤖 Added by blurb_it.
71e547c
vstinner
vstinner reviewed Mar 6, 2026
View reviewed changes
Comment thread Modules/md5module.c Outdated
Hacl_Hash_MD5_free(ptr->hash_state);
if (ptr->hash_state != NULL) {
Hacl_Hash_MD5_free(ptr->hash_state);
ptr->hash_state == NULL;

@vstinner vstinner Mar 6, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be: ptr->hash_state = NULL;

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vstinner
vstinner reviewed Mar 6, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2026-03-06-20-17-45.gh-issue-145376.0F7HFq.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
eendebakpt
eendebakpt commented Mar 6, 2026
View reviewed changes
Comment thread Modules/md5module.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@eendebakpt
Update Modules/md5module.c
1750f48
@vstinner
vstinner enabled auto-merge (squash) March 6, 2026 22:12
@vstinner
vstinner merged commit ae7206e into python:3.13 Mar 6, 2026
42 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@eendebakpt @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.