GeezerVison is showing github.com — gh-145704: Fix typo in `Doc/faq/programming.rst` by benediktjohannes · Pull Request #145705 · python/cpython
Conversation
benediktjohannes
commented
Mar 9, 2026
•
edited by github-actions
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
benediktjohannes
changed the title
gh-145704: Fix Typing: Programming.rst line 1077 "That's a tough one, in general. First, here is list of things to"
gh-145704: Fix typing: Programming.rst line 1077 "That's a tough one, in general. First, here is list of things to"
Mar 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, for small typo fixes, you don't need to create an issue!
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
StanFromIreland and benediktjohannes reacted with thumbs up emoji
picnixz
changed the title
gh-145704: Fix typing: Programming.rst line 1077 "That's a tough one, in general. First, here is list of things to"
gh-145704: Fix typo in Doc/faq/programming.rst
Mar 9, 2026
|
Oops this was my fault. Anyhow, Hugo is already planning to remediate: c5aa74d
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
In general, for small typo fixes, you don't need to create an issue!
Oh, sorry and thanks for the information!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Oops this was my fault. Anyhow, Hugo is already planning to remediate: c5aa74d
Oh, should we then use Hugo's PR? Unforetunately, I can't find any (only for 3.14 and 3.13).
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I rolled it into my other docs PR for main: #145640
|
benediktjohannes reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
I rolled it into my other docs PR for main: #145640
Ah, I see, thanks for the information! Should we then use your PR instead (but maybe we could also use this one because your other PR primarily relies on datetime as far as I see, doesn't it? So it would be kind of confusing if we combined this in one, wouldn't it?)?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Oops this was my fault. Anyhow, Hugo is already planning to remediate: c5aa74d
No worries, this can happen to all of us, not a big thing 👍
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Ah, I see, thanks for the information! Should we then use your PR instead (but maybe we could also use this one because your other PR primarily relies on datetime as far as I see, doesn't it? So it would be kind of confusing if we combined this in one, wouldn't it?)?
In general, we prefer shipping an amendment in the follow-up PR rather than have a single commit. Since this is just a follow-up let's use Hugo's PR.
|
StanFromIreland reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
picnixz
picnixz approved these changes
hugovk
Awaiting requested review from hugovk
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|