GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-144712: Export _Py_jit_entry symbol via PyAPI_DATA by ashm-dev · Pull Request #145840 · python/cpython

Conversation

@ashm-dev

@ashm-dev ashm-dev commented Mar 11, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Duplicate symbol _Py_jit_entry when built with --enable-exterimental-jit #144712

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ashm-dev
ashm-dev requested a review from markshannon as a code owner March 11, 2026 17:31
@bedevere-app bedevere-app Bot mentioned this pull request Mar 11, 2026
Duplicate symbol _Py_jit_entry when built with --enable-exterimental-jit #144712
Open
@bedevere-app bedevere-app Bot added the awaiting review label Mar 11, 2026
Fidget-Spinner
Fidget-Spinner approved these changes Mar 12, 2026
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @jjhelmus does this fix your problems?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 12, 2026
@ashm-dev
ashm-dev requested a review from Fidget-Spinner April 15, 2026 10:52
@Fidget-Spinner

Fidget-Spinner commented Apr 15, 2026

Copy link
Copy Markdown
Member

@diegorusso does this look right to you?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@diegorusso

diegorusso commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Please hold on that. This #146071 needs to go in first and likely this needs to be adapted.

ashm-dev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ashm-dev
pythongh-144712: Export _Py_jit_entry symbol via PyAPI_DATA
00c9eb3
@ashm-dev
ashm-dev force-pushed the gh-144712 branch from 082a57e to 00c9eb3 Compare May 19, 2026 11:27
@ashm-dev

ashm-dev commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@diegorusso #146071 was merged on 2026-05-02. I've rebased onto current main and adapted the initializer (_PyJIT → _PyJIT_Entry). Could you take another look? @Fidget-Spinner the change is small enough that your earlier approval should still apply — pinging in case you'd like to re-confirm before merge.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ashm-dev

ashm-dev commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

The Ubuntu (free-threading) / build and test failure is unrelated — the runner received a shutdown signal mid-run (exit code 143, "runner has received a shutdown signal"). All tests passed up to that point. A rerun should be green.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ashm-dev added 2 commits May 24, 2026 20:48
@ashm-dev
Merge branch 'main' into pythongh-144712
a553b9f
@ashm-dev
Merge branch 'main' into pythongh-144712
cf15bb6
@ashm-dev

ashm-dev commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

@Fidget-Spinner @diegorusso, could you please take another look?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ashm-dev

ashm-dev commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

@diegorusso #146071 landed in May, this PR is rebased on top of it. Can the hold be lifted? @Fidget-Spinner your approval still stands, could you merge once Diego confirms?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Fidget-Spinner

Fidget-Spinner commented Sep 11, 2026

Copy link
Copy Markdown
Member

I'm waiting for Diego.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

diegorusso
diegorusso requested changes Sep 11, 2026
View reviewed changes
Comment thread Python/ceval.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 11, 2026
@bedevere-app

bedevere-app Bot commented Sep 11, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added the awaiting changes label Sep 11, 2026
@ashm-dev
fix(jit): avoid extern on _Py_jit_entry definition
973518d
@ashm-dev

ashm-dev commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels Sep 11, 2026
@bedevere-app

bedevere-app Bot commented Sep 11, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@Fidget-Spinner, @diegorusso: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app
bedevere-app Bot requested a review from diegorusso September 11, 2026 18:13
@ashm-dev
Merge branch 'main' into pythongh-144712
519d58b
@diegorusso diegorusso removed the awaiting change review label Sep 17, 2026
diegorusso
diegorusso approved these changes Sep 17, 2026
View reviewed changes

@diegorusso diegorusso left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. LGTM now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ashm-dev reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added the awaiting merge label Sep 17, 2026
@diegorusso
diegorusso merged commit e8c06d6 into python:main Sep 17, 2026
76 of 77 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 17, 2026
@diegorusso

diegorusso commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Thanks, even though the JIT development is paused, this counts as bugfix which is allowed hence merging.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ashm-dev
ashm-dev deleted the gh-144712 branch September 17, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegorusso diegorusso diegorusso approved these changes
@markshannon markshannon Awaiting requested review from markshannon
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ashm-dev @Fidget-Spinner @diegorusso
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.