GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — gh-144712: Export _Py_jit_entry symbol via PyAPI_DATA by ashm-dev · Pull Request #145840 · python/cpython Conversation
|
|
@diegorusso does this look right to you? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Please hold on that. This #146071 needs to go in first and likely this needs to be adapted. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@diegorusso #146071 was merged on 2026-05-02. I've rebased onto current |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Fidget-Spinner @diegorusso, could you please take another look? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@diegorusso #146071 landed in May, this PR is rebased on top of it. Can the hold be lifted? @Fidget-Spinner your approval still stands, could you merge once Diego confirms? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'm waiting for Diego. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I have made the requested changes; please review again |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for making the requested changes! @Fidget-Spinner, @diegorusso: please review the changes made to this pull request. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change. LGTM now.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thanks, even though the JIT development is paused, this counts as bugfix which is allowed hence merging. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.