GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-145446: Add critical section in functools module for `PyDict_Next` (GH-145487) by brijkapadia · Pull Request #145879 · python/cpython

Conversation

@brijkapadia

@brijkapadia brijkapadia commented Mar 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 17eb035)

Co-authored-by: bkap123 [email protected]

  • Issue: Missing critical sections for PyDict_Next calls in _functoolsmodule.c #145446

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brijkapadia
[3.14] pythongh-145446: Add critical section in functools module for …
f44781d 
…`PyDict_Next` (pythonGH-145487)

(cherry picked from commit 17eb035)

Co-authored-by: bkap123 <[email protected]>
@brijkapadia
brijkapadia requested a review from rhettinger as a code owner March 12, 2026 20:29
This was referenced Mar 12, 2026
Missing critical sections for PyDict_Next calls in _functoolsmodule.c #145446
Closed
gh-145446: Add critical section in functools module for PyDict_Next #145487
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Mar 12, 2026
@encukou
encukou merged commit 4856992 into python:3.14 Mar 13, 2026
49 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Mar 13, 2026
@encukou

encukou commented Mar 13, 2026

Copy link
Copy Markdown
Member

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brijkapadia
brijkapadia deleted the backport-17eb035-3.14 branch March 13, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@brijkapadia @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.