GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-146245: Fix ref/buffer leaks in socketmodule.c on audit hook failure by kimimgo · Pull Request #146247 · python/cpython

Conversation

@kimimgo

@kimimgo kimimgo commented Mar 21, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #146245

Summary

Two leak bugs in socketmodule.c when PySys_Audit raises:

1. getaddrinfo (line 6985)

return NULL skipped cleanup of idna and pstr refs. Changed to
goto err which properly calls Py_XDECREF on both.

2. sock_sendto (line 4811)

return NULL skipped PyBuffer_Release(&pbuf). Added the release
before the return, matching the pattern used in adjacent error paths.

  • Issue: socketmodule.c: Reference and buffer leaks via audit hook failures #146245

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kimimgo
pythongh-146245: Fix ref/buffer leaks in socketmodule.c on audit hook…
25217e7 
… failure

Fix two leak bugs in socketmodule.c when PySys_Audit raises:

1. getaddrinfo: 'return NULL' replaced with 'goto err' to ensure
   idna and pstr refs are properly released via Py_XDECREF.

2. sock_sendto: Added PyBuffer_Release(&pbuf) before 'return NULL'
   to release the Py_buffer when audit hook raises.
@bedevere-app bedevere-app Bot added the awaiting review label Mar 21, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 21, 2026
socketmodule.c: Reference and buffer leaks via audit hook failures #146245
Closed
@kimimgo kimimgo closed this Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

socketmodule.c: Reference and buffer leaks via audit hook failures

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@kimimgo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.