GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — CYGWIN: fix "defined but not used" warnings on mimalloc by carlo-bramini · Pull Request #146572 · python/cpython Conversation
Contributor
Compiling under CYGWIN prints these warning messages: Looking into the code of
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsCompiling under CYGWIN prints these warning messages:
In file included from ../cpython/Objects/mimalloc/prim/prim.c:22,
from ../cpython/Objects/mimalloc/static.c:37,
from ../cpython/Objects/obmalloc.c:23:
../cpython/Objects/mimalloc/prim/unix/prim.c:91:12: warning: ‘mi_prim_access’ defined but not used [-Wunused-function]
91 | static int mi_prim_access(const char *fpath, int mode) {
| ^~~~~~~~~~~~~~
../cpython/Objects/mimalloc/prim/unix/prim.c:88:12: warning: ‘mi_prim_close’ defined but not used [-Wunused-function]
88 | static int mi_prim_close(int fd) {
| ^~~~~~~~~~~~~
../cpython/Objects/mimalloc/prim/unix/prim.c:85:16: warning: ‘mi_prim_read’ defined but not used [-Wunused-function]
85 | static ssize_t mi_prim_read(int fd, void* buf, size_t bufsize) {
| ^~~~~~~~~~~~
../cpython/Objects/mimalloc/prim/unix/prim.c:82:12: warning: ‘mi_prim_open’ defined but not used [-Wunused-function]
82 | static int mi_prim_open(const char* fpath, int open_flags) {
| ^~~~~~~~~~~~
Looking into the code of Objects/mimalloc/prim/unix/prim.c, there is already a conditional block to avoid the generation of such warnings.
Unfortunately, CYGWIN is missing in this list.
However, adding it is very easy and the change is self-explanatory, as you can see.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
Please report those issues upstream. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Excuse me, probably I'm doing a mistake but this doesn't appear to be true. and those fixes are not available into the upstream of mimalloc, by reading the code at https://github.com/microsoft/mimalloc. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Oh, my bad. I thought we legally needed to do this actually, my bad. Please open a new PR (the branch/repo seems to be deleted so I can't reopen the PR) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hum. I am not sure actually. Because ae968d1 has an upstream patch. Let me check. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
See #113141 as well. Now, I'd suggest that you first open an issue so that we can properly track this change. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.