GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-143050: Correct PyLong_FromString() to use _PyLong_Negate() (#145901) by vstinner · Pull Request #147437 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 31, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The long_from_string_base() might return a small integer, when the _pylong.py is used to do conversion. Hence, we must be careful here to not smash it "small int" bit by using the _PyLong_FlipSign().

(cherry picked from commit db5936c)

  • Issue: Remove redundant decref from _PyLong_Negate #143050

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@skirpichev @vstinner
pythongh-143050: Correct PyLong_FromString() to use _PyLong_Negate() (p…
c590419
…ython#145901)

The long_from_string_base() might return a small integer, when the
_pylong.py is used to do conversion.  Hence, we must be careful here to
not smash it "small int" bit by using the _PyLong_FlipSign().

Co-authored-by: Victor Stinner <[email protected]>
(cherry picked from commit db5936c)
@bedevere-app bedevere-app Bot mentioned this pull request Mar 31, 2026
Remove redundant decref from _PyLong_Negate #143050
Closed
@bedevere-app bedevere-app Bot added the skip news label Mar 31, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 31, 2026
gh-143050: correct PyLong_FromString() to use _PyLong_Negate() #145901
Merged
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 31, 2026
@vstinner
Rename has_int_immortal_bit to is_small_int
8143081
@vstinner

vstinner commented Mar 31, 2026

Copy link
Copy Markdown
Member Author

@skirpichev: I backported manually the change to 3.13. I reimplemented _PyLong_IsSmallInt() for 3.13.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
Fix build on Windows
1df4e70
@vstinner
vstinner merged commit 01af34a into python:3.13 Mar 31, 2026
40 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner deleted the long_fromstring13 branch March 31, 2026 15:06
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @skirpichev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.